1877596 - Worker script loader should use original URI for internal scheme

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Description

[Tooru Fujisawa [:arai]]

worker loader uses nsIChannel::GetURI for request's base URL:

https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/dom/workers/loader/NetworkLoadHandler.cpp#191

channel->GetURI(getter_AddRefs(loadContext->mRequest->mBaseURL));

main thread loader uses nsIChannel::GetOriginalURI for internal scheme, to avoid using file:.

https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/dom/script/ScriptLoader.cpp#3865-3875

nsCOMPtr<nsIURI> uri;
rv = channel->GetOriginalURI(getter_AddRefs(uri));
NS_ENSURE_SUCCESS(rv, rv);

// Fixup moz-extension: and resource: URIs, because the channel URI will
// point to file:, which won't be allowed to load.
if (uri && IsInternalURIScheme(uri)) {
  aRequest->mBaseURL = uri;
} else {
  channel->GetURI(getter_AddRefs(aRequest->mBaseURL));
}

This blocks bug 1803810, because the module URI doesn't match between sync and async loaders, due to resource: vs file:, and results in loading module twice.

worker loader should do the same as main thread loader

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1877596 - Use original URL as base URL for internal scheme also in worker. r?jonco!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/778e884de4e5
Use original URL as base URL for internal scheme also in worker. r=jonco,dom-storage-reviewers,janv,dom-worker-reviewers,smaug

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/778e884de4e5

Comment 4

[Andrew McCreight [:mccr8]]

arai, should this get backported somewhere if it fixes bug 1876047? I don't know how common of an issue that is. Thanks.

Comment 5

[Tooru Fujisawa [:arai]]

I doubt this fixes bug 1876047's issue.

The change for the worker URI can lead to different behavior for internal resources if relative/absolute path is used against those URLs which goes beyond the mapping of each directory (so, the file pointed by resolved path results in different file than file:// URI, for example the case in dom/quota),
but this doesn't directly affect hang or GC.

Possibilities are:

• The fix for dom/quota/test/modules/system/worker/Utils.js changed something
• There's some other place that resulted in different behavior due to the relative/absolute path, possibly in in-tree code, or extensions, or something injected via AutoConfig etc (for example, if the hang is caused by some script and the script stops working with this change, that can explain the behavior)

anyway, I'm hesitant to ask for uplift without understanding the issue and reasoning behind the fix.

Forwarding to janv to see if the fix for dom/quota can be related to the issue.

Comment 6

[Jan Varga [:janv]]

(In reply to Tooru Fujisawa [:arai] from comment #5)

Possibilities are:

• The fix for dom/quota/test/modules/system/worker/Utils.js changed something

Utils.js is only used in our tests