1877649 - Remove unused storage access flag `eSessionScoped`

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P3)

Description

[Emma Zühlcke [:emz]]

The flag isn't set anywhere, there are only a few checks left: https://searchfox.org/mozilla-central/search?q=eSessionScoped

Comment 1

[Razvan Cojocaru]

Attachment: Bug 1877649 - Remove unused storage access flag `eSessionScoped`. r?pbz

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rzvncj, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Razvan Cojocaru]

There is nothing to be done on my end, as far as I know. Unless somebody requests any changes, I think the patch is ready to go in.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

The landing request should be made but it's forgotten. I just push it 😉

(In general external contributors need to ask the reviewer to land the patch, otherwise the reviewer would assume the patch author would do it the self even if the author doesn't have the permission. There's no easy way to tell whether a user has a permission or not, so this is a bit confusing 😅)

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Can we also add some guide for contributors about how to request landing in comment #3? 👀

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Oh no I didn't intend this...

Comment 8

[Razvan Cojocaru]

(In reply to Kagami [:saschanaz] (they/them) OOO until 2024-03-26 from comment #5)

The landing request should be made but it's forgotten. I just push it 😉

(In general external contributors need to ask the reviewer to land the patch, otherwise the reviewer would assume the patch author would do it the self even if the author doesn't have the permission. There's no easy way to tell whether a user has a permission or not, so this is a bit confusing 😅)

I see. I didn't know, and thought everyone knew I can't push patches. :)
Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e43f29f0802
Remove unused storage access flag `eSessionScoped`. r=pbz,dom-storage-reviewers,janv,webidl,saschanaz

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8e43f29f0802

Comment 11

[Suhaib Mujahid [:suhaib]]

(In reply to Kagami [:saschanaz] (they/them) OOO until 2024-03-26 from comment #6)

Can we also add some guide for contributors about how to request landing in comment #3? 👀

I think that would be useful. Could you please file an issue in the BugBot repo and provide more details on how you envision that?