Closed Bug 1877649 Opened 8 months ago Closed 6 months ago

Remove unused storage access flag `eSessionScoped`

Categories

(Core :: Privacy: Anti-Tracking, task, P3)

task

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: pbz, Assigned: rzvncj, Mentored)

References

Details

(Keywords: priv-triaged, Whiteboard: [lang=c++])

Attachments

(1 file)

The flag isn't set anywhere, there are only a few checks left: https://searchfox.org/mozilla-central/search?q=eSessionScoped

Assignee: nobody → rzvncj
Status: NEW → ASSIGNED
Duplicate of this bug: 1776136

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rzvncj, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(rzvncj)
Flags: needinfo?(krosylight)

There is nothing to be done on my end, as far as I know. Unless somebody requests any changes, I think the patch is ready to go in.

Flags: needinfo?(rzvncj)

The landing request should be made but it's forgotten. I just push it 😉

(In general external contributors need to ask the reviewer to land the patch, otherwise the reviewer would assume the patch author would do it the self even if the author doesn't have the permission. There's no easy way to tell whether a user has a permission or not, so this is a bit confusing 😅)

Flags: needinfo?(krosylight)

Can we also add some guide for contributors about how to request landing in comment #3? 👀

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Flags: needinfo?(smujahid)
Resolution: --- → WONTFIX

Oh no I didn't intend this...

Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

(In reply to Kagami [:saschanaz] (they/them) OOO until 2024-03-26 from comment #5)

The landing request should be made but it's forgotten. I just push it 😉

(In general external contributors need to ask the reviewer to land the patch, otherwise the reviewer would assume the patch author would do it the self even if the author doesn't have the permission. There's no easy way to tell whether a user has a permission or not, so this is a bit confusing 😅)

I see. I didn't know, and thought everyone knew I can't push patches. :)
Thanks!

Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e43f29f0802 Remove unused storage access flag `eSessionScoped`. r=pbz,dom-storage-reviewers,janv,webidl,saschanaz
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch

(In reply to Kagami [:saschanaz] (they/them) OOO until 2024-03-26 from comment #6)

Can we also add some guide for contributors about how to request landing in comment #3? 👀

I think that would be useful. Could you please file an issue in the BugBot repo and provide more details on how you envision that?

Flags: needinfo?(smujahid)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: