1877664 - Crash in [@ IPCError-content | MakeIpcFailure SpawnFolderPicker]

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/d8f903c8-98e9-4321-b5a1-2dbcf0240128

MOZ_CRASH Reason: MOZ_CRASH(IPC error)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::widget::filedialog::detail::LogProcessingError  widget/windows/filedialog/WinFileDialogCommands.cpp:300
1  xul.dll  mozilla::ipc::IPCResult::FailImpl  ipc/glue/ProtocolUtils.cpp:68
2  xul.dll  mozilla::ipc::IPCResult::Fail  ipc/glue/ProtocolUtils.h:379
2  xul.dll  mozilla::widget::filedialog::WinFileDialogChild::MakeIpcFailure<18>  widget/windows/filedialog/WinFileDialogChild.cpp:49
3  xul.dll  mozilla::widget::filedialog::WinFileDialogChild::RecvShowFolderDialog::<lambda_4>::operator const  widget/windows/filedialog/WinFileDialogChild.cpp:98
3  xul.dll  mozilla::MozPromise<mozilla::Maybe<nsTString<char16_t> >, long, 1>::InvokeMethod  xpcom/threads/MozPromise.h:654
3  xul.dll  mozilla::MozPromise<mozilla::Maybe<nsTString<char16_t> >, long, 1>::InvokeCallbackMethod  xpcom/threads/MozPromise.h:685
3  xul.dll  mozilla::MozPromise<mozilla::Maybe<nsTString<char16_t> >, long, 1>::ThenValue<`lambda at /builds/worker/checkouts/gecko/widget/windows/filedialog/WinFileDialogChild.cpp:92:11', `lambda at /builds/worker/checkouts/gecko/widget/windows/filedialog/WinFileDialogChild.cpp:95:11'>::DoResolveOrRejectInternal  xpcom/threads/MozPromise.h:874
4  xul.dll  mozilla::MozPromise<mozilla::net::SocketDataArgs, mozilla::ipc::ResponseRejectReason, 1>::ThenValueBase::ResolveOrRejectRunnable::Run  xpcom/threads/MozPromise.h:490
5  xul.dll  mozilla::RunnableTask::Run  xpcom/threads/TaskController.cpp:578

This crash seems to have been introduced by bug 1837079, Raymond can you have a look please?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1837079

Comment 2

[Ray Kraesig [:rkraesig]]

These are all failing with E_INVALIDARG, which weakly suggests it's something like what happened on the test machines earlier. Unfortunately, since refactoring the file picker to be properly asynchronous (bug 1858225), none of the relevant data is still on the stack; it will have to be explicitly preserved to be available in dumps for further analysis.

(This is sufficiently similar to the tedium I'm going through with the utility-process-launch code as to suggest that I should step back and try to unify these approaches.)

At any rate, this doesn't appear to be significantly impacting users; the fallback to in-process file picker appears to be successful (as evidenced by the lack of a "total failure" line on url this graph), so S4.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.