1877831 - New test262 failures with Iterator Helpers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Dan Minor [:dminor]]

While updating test262 in Bug 1877822, I hit a handful of new failures for the iterator helpers feature:
--enable-iterator-helpers test262/built-ins/Iterator/prototype/constructor/prop-desc.js
--enable-iterator-helpers test262/built-ins/Iterator/prototype/constructor/weird-setter.js
--enable-iterator-helpers test262/built-ins/Iterator/prototype/Symbol.toStringTag/prop-desc.js
--enable-iterator-helpers test262/built-ins/Iterator/prototype/Symbol.toStringTag/weird-setter.js

Comment 1

[Michael Ficarra]

It looks like you've just not updated your implementation of these properties to use the weird setters. We made a breaking change for web compat purposes at https://github.com/tc39/proposal-iterator-helpers/pull/287.

Comment 2

[Dan Minor [:dminor]]

(In reply to Michael Ficarra from comment #1)

It looks like you've just not updated your implementation of these properties to use the weird setters. We made a breaking change for web compat purposes at https://github.com/tc39/proposal-iterator-helpers/pull/287.

That's right, thanks for the reminder :)

Comment 3

[Tom S]

Attachment: Bug 1877831 - Implement the Iterator helpers' funky getter/setters. r?#spidermonkey-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/931d7c9e5dea
Implement the Iterator helpers' funky getter/setters. r=dminor

Comment 5

[Cristian Tuns]

Backed out for causing SM bustages in proto.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | non262/Iterator/proto.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so") [0.0 s]

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da1cb5d4f552
Implement the Iterator helpers' funky getter/setters. r=dminor

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/da1cb5d4f552