Closed
Bug 1877842
Opened 10 months ago
Closed 10 months ago
Migrate GVST metrics in the performances namespaces to pure glean
Categories
(Toolkit :: Telemetry, task, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
124 Branch
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: perry.mcmanis, Assigned: chutten)
References
(Regressed 1 open bug)
Details
Attachments
(2 files)
As seen here: https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/geckoview/streaming/metrics.yaml
this covers perf and all its subcategories
Assignee | ||
Updated•10 months ago
|
Assignee: nobody → chutten
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Comment 1•10 months ago
|
||
Most are brought over straightforwardly, their Telemetry callsites reworded
to use Glean, with mirroring to the Telemetry probes taken care of by the Glean
Interface For Firefox Telemetry (see the telemetry_mirror property).
There was only one special case:
- PERF_DOM_CONTENT_LOADED_FROM_RESPONSESTART_MS doesn't exist.
As such neither it nor performance.pageload.dcl_responsestart ever reported
data.
So we removed them to tidy it away.
(PERF_DOM_CONTENT_LOADED_TIME_FROM_RESPONSESTART_MS remains unchanged.) - PERF_DOM_CONTENT_LOADED_MS doesn't exist.
However, I'd already mistakenly read it as PERF_DOM_CONTENT_LOADED_TIME_MS,
and successfully migrated it for performance.pageload.dcl, so it gets a pass.
Assignee | ||
Comment 2•10 months ago
|
||
None of DESERIALIZE_{BYTES|ITEMS|US}
were enabled to be collected in
geckoview mode, so they never reported data.
Updated•10 months ago
|
Attachment #9378643 -
Attachment description: Bug 1877842 - Remove deserialize GVST metrics r?perry.mcmanis!,sfink! → Bug 1877842 - Migrate deserialize GVST metrics r?perry.mcmanis!,sfink!
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b59b49b0286
Migrate performance GVST probes r=perry.mcmanis,denispal
https://hg.mozilla.org/integration/autoland/rev/959f9bf4892d
Migrate deserialize GVST metrics r=perry.mcmanis,sfink
Comment 4•10 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2b59b49b0286
https://hg.mozilla.org/mozilla-central/rev/959f9bf4892d
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•