Closed Bug 1877842 Opened 5 months ago Closed 5 months ago

Migrate GVST metrics in the performances namespaces to pure glean

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: perry.mcmanis, Assigned: chutten)

References

(Regressed 1 open bug)

Details

Attachments

(2 files)

Blocks: 1877843
Assignee: nobody → chutten
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P1

Most are brought over straightforwardly, their Telemetry callsites reworded
to use Glean, with mirroring to the Telemetry probes taken care of by the Glean
Interface For Firefox Telemetry (see the telemetry_mirror property).

There was only one special case:

  • PERF_DOM_CONTENT_LOADED_FROM_RESPONSESTART_MS doesn't exist.
    As such neither it nor performance.pageload.dcl_responsestart ever reported
    data.
    So we removed them to tidy it away.
    (PERF_DOM_CONTENT_LOADED_TIME_FROM_RESPONSESTART_MS remains unchanged.)
  • PERF_DOM_CONTENT_LOADED_MS doesn't exist.
    However, I'd already mistakenly read it as PERF_DOM_CONTENT_LOADED_TIME_MS,
    and successfully migrated it for performance.pageload.dcl, so it gets a pass.

None of DESERIALIZE_{BYTES|ITEMS|US} were enabled to be collected in
geckoview mode, so they never reported data.

Depends on: 1879192
Attachment #9378643 - Attachment description: Bug 1877842 - Remove deserialize GVST metrics r?perry.mcmanis!,sfink! → Bug 1877842 - Migrate deserialize GVST metrics r?perry.mcmanis!,sfink!
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b59b49b0286
Migrate performance GVST probes r=perry.mcmanis,denispal
https://hg.mozilla.org/integration/autoland/rev/959f9bf4892d
Migrate deserialize GVST metrics r=perry.mcmanis,sfink
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Regressions: 1880972
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: