1877850 - Convert callers of ReflowInput physical size accessors to use logical ones

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

For usage like nsSize(ComputedWidth(), ComputedHeight()) [1], it requires two IsVertical() checks [2], but GetPhysicalSize() only needs one.

[1] https://searchfox.org/mozilla-central/rev/6e2e933cd6b7931e1d4e8bd8af8daa9788b27760/layout/generic/ReflowInput.h#402
[2] https://searchfox.org/mozilla-central/rev/6e2e933cd6b7931e1d4e8bd8af8daa9788b27760/layout/generic/WritingModes.h#960,964
[3] https://searchfox.org/mozilla-central/rev/6e2e933cd6b7931e1d4e8bd8af8daa9788b27760/layout/generic/WritingModes.h#989-990

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1877850 Part 1 - Convert callers of ReflowInput physical size accessors to use logical ones. r?#layout,jfkthame

ReflowInput's computed sizes and border&padding are stored in logical
coordinates, so accessing the physical version is slower [1]. This patch
converts as many callers as possible to use logical coordinates.

This patch doesn't change behavior.

[1] For example, accessing ComputedWidth() and ComputedHeight() needs two
IsVertical() check, but `GetPhysicalSize() only needs one.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1877850 Part 2 - Rewrite ComputedSizeAsContainerIfConstrained() using logical coordinates, and use it in BlockReflowState. r?#layout,jfkthame

This patch doesn't change behavior.

[1] For example, accessing ComputedWidth() and ComputedHeight() needs two
IsVertical() check, but `GetPhysicalSize() only needs one.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05c1c99a6ed1
Part 1 - Convert callers of ReflowInput physical size accessors to use logical ones. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/085a323ab16c
Part 2 - Rewrite ComputedSizeAsContainerIfConstrained() using logical coordinates, and use it in BlockReflowState. r=dholbert

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/05c1c99a6ed1
https://hg.mozilla.org/mozilla-central/rev/085a323ab16c