Closed Bug 1878014 Opened 4 months ago Closed 4 months ago

WebSocketConnection._log() should respect "remote.log.truncate" preference setting

Categories

(Remote Protocol :: Agent, defect, P2)

defect
Points:
1

Tracking

(firefox124 fixed)

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

(Whiteboard: [webdriver:m10])

Attachments

(1 file)

The given method doesn't care about the actual value as set by the preference and always truncates the resulting response value:
https://searchfox.org/mozilla-central/rev/76cb3efe3b19e649bf675bb6ec5d4af8109b9771/remote/shared/WebSocketConnection.sys.mjs#54-65

This actually blocks me with the investigation of remaining Puppeteer P2 failures. The fix is easy.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [webdriver:m10]
Points: --- → 1
Severity: -- → S3
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4348a1a2e5fd
[remote] Do not truncate long WebSocket response payloads if "remote.log.truncate" is not set. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: