1878062 - For tracked SPAs, accurately remove listeners from the content process and content specific engagements that cause search page changes

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[James Teow [:jteow]]

While smoke testing the SPA patch, there were a couple errors I didn't notice related to the content process:

1. In SearchSERPTelemetryChild, addEventListenerToElements doesn't just get called once per page load, so clobbering a possible existing WeakMap value will result in some listeners not being unloaded when manually tasked to do so.

2. If we register a click event in the content process that we want to take precedence over information sent in the network, namely clicking an auto-suggested term or submitting the search, a check for an engagement will occur before the message from the child is sent.

We could first check if a submitted event was sent in the document, at which point we should not register an additional event.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1878062 - Check for a possible content process event before manually registering an engagement event - r?standard8!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fd4633cdd0b
Check for a possible content process event before manually registering an engagement event - r=scunnane

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5fd4633cdd0b