1878109 - Failing WPT css/css-flexbox/align-content-wrap-003.html

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Thomas Wisniewski [:twisniewski]]

See https://wpt.fyi/results/css/css-flexbox/align-content-wrap-003.html

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Similar to Bug 1836206, in flex container, we should also use safe in the fallback for these align-content values: space-between, space-around, and space-evenly.

The code is at https://searchfox.org/mozilla-central/rev/3076c9156ef84aae253ffdc1d391e0bfab2c406b/layout/generic/nsFlexContainerFrame.cpp#3670-3693

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1878109 - Fix align-content's distributed alignment fallback for flex. r?dholbert

Similar to Bug 1836206 and per the CSS Align spec, 'space-between',
'space-around', and 'space-evenly' should use a "safe" fallback alignment when
overflow occurs.

This patch sets alignContentFlags to StyleAlignFlags::SAFE to fix the
fallback, and moves overflow-handling code to a later point so that it can catch
overflow more broadly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6972ade9ee51
Fix align-content's distributed alignment fallback for flex. r=dholbert

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6972ade9ee51