Add herald rule for devtools-reviewers
Categories
(Conduit :: Administration, task)
Tracking
(Not tracked)
People
(Reporter: aminomancer, Assigned: dkl)
References
(Blocks 1 open bug)
Details
Hello,
Could we create a new herald rule that adds the omc-reviewers group as a blocking reviewer when reviewers already exists, and files under the following paths are modified:
browser/components/asrouter/
browser/components/aboutwelcome/
browser/components/messagepreview/
browser/components/uitour/
toolkit/components/messaging-system/
Is it a lot of trouble to add individual file paths for Fluent strings? We also own these Fluent files:
browser/locales/en-US/browser/newtab/onboarding.ftl
browser/locales/en-US/browser/spotlight.ftl
browser/locales/en-US/browser/newtab/asrouter.ftl
browser/locales/en-US/browser/featureCallout.ftl
Unfortunately they would have to be specified individually, as there are unrelated files in browser/ and browser/newtab.
Thank you!
|
Assignee | |
Comment 2•2 years ago
|
||
(In reply to Shane Hughes [:aminomancer] from comment #0)
Hello,
Could we create a new herald rule that adds the
omc-reviewersgroup as a blocking reviewer whenreviewersalready exists, and files under the following paths are modified:browser/components/asrouter/ browser/components/aboutwelcome/ browser/components/messagepreview/ browser/components/uitour/ toolkit/components/messaging-system/Is it a lot of trouble to add individual file paths for Fluent strings? We also own these Fluent files:
browser/locales/en-US/browser/newtab/onboarding.ftl browser/locales/en-US/browser/spotlight.ftl browser/locales/en-US/browser/newtab/asrouter.ftl browser/locales/en-US/browser/featureCallout.ftlUnfortunately they would have to be specified individually, as there are unrelated files in browser/ and browser/newtab.
yes but I will need to do separate herald rules. not an issue though.
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
Reporter | |
Comment 4•2 years ago
|
||
Thank you! Much appreciated.
Description
•