1878168 - The firefox download link downloads "Firefox Setup 122.0.exe" on Linux

Status: NEW

(Testing :: geckodriver, defect, P3)

Description

[fohrloop]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36

Steps to reproduce:

This is not about Firefox but the mozilla.org documentation.

1. Go to https://firefox-source-docs.mozilla.org/testing/geckodriver/Usage.html
2. Click the https://download.mozilla.org/?product=firefox-latest&os=linux

or go directly to https://download.mozilla.org/?product=firefox-latest

(Tested on On Ubuntu 22.04 using Chrome 121.0.6167.85 )

Actual results:

This downloads "Firefox Setup 122.0.exe".

Expected results:

Expecting a .deb package or similar

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sam Foster [:sfoster] (he/him)]

It looks like the link in Usage.md to download the latest firefox release on this page is getting badly encoded, resulting in https://download.mozilla.org/?product=firefox-latest&os=linux - the & is entity-ized so the target doesnt get the os param and defaults to the windows .exe file.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for the report! We should indeed get it fixed. Fohrloop, would you maybe interested to fix it on your own? I'ld be happy to mentor you through the process.

Comment 4

[James Graham [:jgraham]]

I can't work out a way to correctly encode an ampersand in a URL in a markdown file in Sphinx. Bug 1828390 is about the same issue, and doesn't seem to have any progress. So I don't think this is actually straightforward to fix.

Comment 5

[fohrloop]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #3)

Thanks for the report! We should indeed get it fixed. Fohrloop, would you maybe interested to fix it on your own? I'ld be happy to mentor you through the process.

Thanks for asking! My other projects need my attention more currently so I'll leave it here for now.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To not being blocked maybe we could just link to the general Firefox download page: https://www.mozilla.org/firefox/download/thanks/?

I have also tested https://download.mozilla.org/?product=firefox-latest and that downloads the exe file as well even when being on MacOS. Ben, I assume that this is probably not wanted, or? Also would it be ok to use the above page instead from https://firefox-source-docs.mozilla.org/testing/geckodriver/Usage.html?

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #6)

To not being blocked maybe we could just link to the general Firefox download page: https://www.mozilla.org/firefox/download/thanks/?

I have also tested https://download.mozilla.org/?product=firefox-latest and that downloads the exe file as well even when being on MacOS. Ben, I assume that this is probably not wanted, or? Also would it be ok to use the above page instead from https://firefox-source-docs.mozilla.org/testing/geckodriver/Usage.html?

I don't have any strong opinion on the behaviour here, because IMO download.mozilla.org is more or less just an API that's used by www.mozilla.org and other places.

Nick - do you have any concerns about having download.mozilla.org stop redirecting to a Windows installer as fallback when incomplete information is provided by the client?

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to [e-mail] (:bhearsum) from comment #7)

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #6)

To not being blocked maybe we could just link to the general Firefox download page: https://www.mozilla.org/firefox/download/thanks/?

I have also tested https://download.mozilla.org/?product=firefox-latest and that downloads the exe file as well even when being on MacOS. Ben, I assume that this is probably not wanted, or? Also would it be ok to use the above page instead from https://firefox-source-docs.mozilla.org/testing/geckodriver/Usage.html?

I don't have any strong opinion on the behaviour here, because IMO download.mozilla.org is more or less just an API that's used by www.mozilla.org and other places.

Nick - do you have any concerns about having download.mozilla.org stop redirecting to a Windows installer as fallback when incomplete information is provided by the client?

No. I'd rather an API complain in error situations (no OS provided!) than have an unhelpful default. I have no idea how frequent links to that without os= are -- hopefully not frequent.

Comment 9

[[e-mail] (:bhearsum)]

I filed https://github.com/mozilla-services/go-bouncer/issues/376 for this. Also flagging Will, who ostensibly owns Bouncer at the moment.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to James Graham [:jgraham] from comment #4)

I can't work out a way to correctly encode an ampersand in a URL in a markdown file in Sphinx. Bug 1828390 is about the same issue, and doesn't seem to have any progress. So I don't think this is actually straightforward to fix.

When I use & or & in this live Markdown preview tool the link is correctly rendered.

Could this maybe be an issue with sphinx?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Dunno, sorry!

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Andrew, I noticed that you should be in touch with sphinx. Do you have an answer to the problem as mentioned in comment 10?

Comment 13

[Andrew Halberstadt [:ahal]]

Sphinx doesn't do any actual rendering of markdown (or rst for that matter). There are likely hundreds of markdown parsers out there, but the one we use is called MyST. In bug 1828390 Nick pointed out we're using a very old version and suggests that the issue is fixed in more modern versions. So we probably have to update.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that we are blocked by bug 1885098 there is not much that we can do in the short term. And it's not on our list for M11.