MsgIncomingServer and SmtpServer have observers that are not cleaned up if the server is removed
Categories
(MailNews Core :: Networking, defect)
Tracking
(thunderbird_esr115 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr115 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-esr115+
|
Details | Review |
The constructor of MsgIncomingServer adds an observer for passwordmgr-storage-changed, but if the server is removed this observer isn't cleaned up.
|
Assignee | |
Comment 1•4 months ago
|
||
|
|
Assignee | |
Comment 2•4 months ago
|
||
It turns out SmtpServer has the same problem.
|
||
Updated•4 months ago
|
|
|
||
Updated•4 months ago
|
|
|
Assignee | |
Updated•4 months ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/64f27806a0dc
Clean up observers of passwordmgr-storage-changed in server objects. r=mkmelin
|
|
Assignee | |
Comment 4•2 months ago
|
||
Comment on attachment 9377888 [details]
Bug 1878257 - Clean up observers of passwordmgr-storage-changed in server objects. r=#thunderbird-reviewers
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Memory leak
Testing completed (on c-c, etc.): In beta since 124
Risk to taking this patch (and alternatives if risky): Low
|
||
Updated•1 month ago
|
|
|
||
Comment 5•1 month ago
|
||
Comment on attachment 9377888 [details]
Bug 1878257 - Clean up observers of passwordmgr-storage-changed in server objects. r=#thunderbird-reviewers
[Triage Comment]
Approved for esr115
|
||
Comment 6•1 month ago
|
||
| bugherder uplift | ||
Description
•