1878355 - Failing WPT accname/name/comp_name_from_content.html

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Thomas Wisniewski [:twisniewski]]

See https://wpt.fyi/results/accname/name/comp_name_from_content.html

Comment 1

[Nathan LaPré]

Noting for later that we're currently failing 13 tests in this file.

Comment 2

[Nathan LaPré]

Attachment: Bug 1878355: Include display: inline-block when adding spaces between text alternatives, r?Jamie

When Gecko computes the text alternative for accessibles, it avoids jamming
names together without spaces between them for elements with block-like CSS
display styles. This revision adds "inline-block" to that block-like list. It
also removes the relevant expected failures from the WPT meta file.

Comment 3

[Nathan LaPré]

Note that the above patch only fixes 3 of the failures in this file. The bug should remain open even after that patch lands.

Comment 4

[Nathan LaPré]

After a bit of investigation, I think that fixing the following test failures in this test file are dependent on the resolution of Bug 1281158:

• button name from fallback content with ::before and ::after
• heading name from fallback content with ::before and ::after
• link name from fallback content with ::before and ::after
• button name from fallback content mixing attr() and strings with ::before and ::after
• heading name from fallback content mixing attr() and strings with ::before and ::after
• link name from fallback content mixing attr() and strings with ::before and ::after

The resolution of that bug might fix those six tests, but it's worth double-checking once that's done.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32fea4291314
Include display: inline-block when adding spaces between text alternatives, r=Jamie

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/32fea4291314

Comment 7

[Nathan LaPré]

Attachment: Bug 1878355: Restrict ARIA IDREF, node consultation in acc name traversals, r?Jamie

The Acc Name spec requires that, "if [...] the current node is not already part
of an ongoing aria-labelledby or aria-describedby traversal," UAs should not
continue to follow aria-labelledby / aria-describedby IDREFs. It also requires
that "[e]ach node in the subtree is consulted only once." This revision
implements these rules and updates relevant tests, including removal of WPT
expected-fail designations. The concept of sInitiatorAcc has been expanded - we
now track all referenced accessibles. We also track whether we're in an
aria-labelledby or aria-describedby traversal.

Comment 8

[James Teh [:Jamie]]

Simple test case for CSS content alt text:

data:text/html,<style> button::before { content: url("https://via.placeholder.com/10x10.png") / "before"; } </style><button>button

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e47a3fef5c4
Restrict ARIA IDREF, node consultation in acc name traversals, r=Jamie

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9e47a3fef5c4

Comment 11

[Nathan LaPré]

Two failing tests remain in this test file, both of which I think are invalid. Discussing that here. My hope is that, once we resolve that issue in the web platform tests repo, we'll be able to close this issue with no other patches to Gecko.