Open Bug 1878368 Opened 2 years ago Updated 1 year ago

Update OperationRequestedAction to Include Translate and Restore and Rename TranslateSuccessAction and TranslateExceptionAction

Categories

(Firefox for Android :: Translations, enhancement, P3)

Product:
Firefox for Android
Component:
Translations
Platform:
All
Android
Type:
enhancement

Tracking

()

People

(Reporter: olivia, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][foundation])

For clearer code, recommend adding an action for OperationRequestedAction TRANSLATE and RESTORE here that redirects to the right call. Reducer should not change.

Recommend something like:

OperationRequestedAction -> ...

  TranslationOperation.TRANSLATE -> context.store.dispatch(TranslateAction)
  TranslationOperation.RESTORE -> context.store.dispatch(TranslateRestoreAction)
Severity: -- → N/A
Priority: -- → P3
Summary: Update OperationRequestedAction to Include → Update OperationRequestedAction to Include Translate and Restore
Whiteboard: [fxdroid][foundation]

Because the scope of this bug is small, I think this would also be a good place to rename the following actions:

TranslateSuccessAction -> SuccessAction
TranslateExceptionAction -> ExceptionAction

This rename should improve readability due to naming parallelism with other TranslationOperations . ("Translate" is a bit misleading prefix, etc.)

Summary: Update OperationRequestedAction to Include Translate and Restore → Update OperationRequestedAction to Include Translate and Restore and Rename TranslateSuccessAction and TranslateExceptionAction
Blocks: 1909674
You need to log in before you can comment on or make changes to this bug.