1878371 - Failing WPT css/css-grid/alignment/grid-content-distribution-[026|027].html

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Thomas Wisniewski [:twisniewski]]

See:

• https://wpt.fyi/results/css/css-grid/alignment/grid-content-distribution-026.html (screenshots)
• https://wpt.fyi/results/css/css-grid/alignment/grid-content-distribution-027.html (screenshots)

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

It looks like this is about fallback alignment behavior when the grid item (and hence the grid tracks) are larger than the grid.

In http://wpt.live/css/css-grid/alignment/grid-content-distribution-026.html at least, the grid track is wider than the grid, and it uses space-evenly alignment, and the test seems to expect that to end up with start alignment, but we use unsafe-center alignment (overflowing equally off the left and right sides, and off bottom/top sides). So we place it at the wrong position.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1878371 - Fix overflow alignment for distributed alignment values for grid. r?#layout-grid-reviewers

Per the CSS Align specification, 'space-between', 'space-around', and
'space-evenly' should use a "safe" fallback alignment when overflow occurs. This
patch implements that behavior, renames the function for clarity, and removes
unused parameters.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/187010a14e97
Fix overflow alignment for distributed alignment values for grid. r=layout-grid-reviewers,dholbert

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/187010a14e97