1878395 - Move the label exception checks into the try-catch block of AccessibilityUtils

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Per the recommendation from Jamie, we should consider moving the isUnlabeledUrlBarCombobox(accessible), isUnlabeledUrlBarOption(accessible), and isUnlabeledMenuitem(accessible) checks down here:

This makes the exception more specific. With that change, it won't be enough for the accessible to exist but have no name; the accessible must actually disappear after having no name. Most of the time, this will make no practical difference because clicking a URL bar option or menu item pretty much always makes it disappear. Still, it doesn't hurt to be super explicit about our exceptions.

Comment 1

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Attachment: Bug 1878395 - Move label exception checks closer to their failing blocks of AccessibilityUtils. r=Jamie!

This would make these exceptions more specific. After moving the isUnlabeledUrlBarOption() and isUnlabeledMenuitem() checks in the try-catch block, it won't be enough for the accessible to exist but have no name; the accessible must actually disappear after having no name. Most of the time, this will make no practical difference because clicking a URL bar option or menu item pretty much always makes it disappear. But the AccessibilityUtils would be more explicit about its exceptions.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ayeddi, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Resolved minor test issues and had a try run after rebasing to the current central. Pushing to Lando now.

Apologies for the ping, Jamie :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f89f18d3af8
Move label exception checks closer to their failing blocks of AccessibilityUtils. r=Jamie

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1f89f18d3af8