1878420 - Use `AbortSignal.any` and `AbortSignal.timeout` in bookmark sync

Status: RESOLVED FIXED

(Firefox :: Sync, task, P3)

Description

[Lina Butler (ex-Mozilla)]

SyncedBookmarksMirror.sys.mjs has a helper called anyAborted that takes two signals, and returns a new signal that aborts if either of the inputs abort. The bookmarks sync engine also uses a Watchdog helper that aborts merges that take longer than 5 minutes.

Bug 1830781 implemented AbortSignal.any(), and bug 1753309 implemented AbortSignal.timeout(), for these very use cases. Let's replace our hand-rolled helpers with them!

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1878420 - Use `AbortSignal.any()` in the bookmarks mirror. r?#sync-reviewers!

AbortSignal.any() is the standardized version of our anyAborted
helper.

Comment 2

[Lina Butler (ex-Mozilla)]

We can't replace Async.Watchdog with AbortSignal.timeout() yet, because of bug 1879215, but we can use AbortSignal.any().

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46c2a902fc4d
https://hg.mozilla.org/integration/autoland/rev/4e411b993ac0
Use `AbortSignal.any()` in the bookmarks mirror. r=sync-reviewers,places-reviewers,mak,markh

Comment 4

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/4e411b993ac0