1878433 - Clean up in nsIFrame and nsCanvasFrame

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

See the commit message for detail.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1878433 Part 1 - Remove unused #defines in nsIFrame.cpp. r?#layout

The three #defines are not used elsewhere.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1878433 Part 2 - Remove broken code within DEBUG_CANVAS_FOCUS define. r?#layout

The code no longer compiles because most of the functions such as
EventStateManager::GetFocusedContent(), PresContext::GetContainer(), and
nsIDocShell::GetHasFocus() are gone.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1878433 Part 3 - Sort #includes in nsCanvasFrame.cpp, and removed some unused ones. r?#layout

Also, remove the following because they are not used.

• #include "AccessibleCaretEventHub.h"
• #include "nsPrintfCString.h"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/479cc28c3859
Part 1 - Remove unused #defines in nsIFrame.cpp. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ebbd87b3190b
Part 2 - Remove broken code within DEBUG_CANVAS_FOCUS define. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6e69ec3ca9b3
Part 3 - Sort #includes in nsCanvasFrame.cpp, and removed some unused ones. r=dholbert

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/479cc28c3859
https://hg.mozilla.org/mozilla-central/rev/ebbd87b3190b
https://hg.mozilla.org/mozilla-central/rev/6e69ec3ca9b3