1878462 - Intermittent [TV] browser/base/content/test/tabs/browser_window_open_modifiers.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=445786793&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/C1e9oeQXQyS00zaWIYQxHw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/C1e9oeQXQyS00zaWIYQxHw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

TEST-PASS | browser/base/content/test/tabs/browser_window_open_modifiers.js | #instant with y and {"ctrlKey":true,"shiftKey":true} opened a popup window - 
[task 2024-02-03T05:39:12.515Z] 05:39:12     INFO - Buffered messages logged at 05:39:11
[task 2024-02-03T05:39:12.522Z] 05:39:12     INFO - Leaving test bound 
[task 2024-02-03T05:39:12.523Z] 05:39:12     INFO - Buffered messages finished
[task 2024-02-03T05:39:12.525Z] 05:39:12     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_window_open_modifiers.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2024-02-03T05:39:12.525Z] 05:39:12     INFO - GECKO(1346) | MEMORY STAT | vsize 130563300MB | residentFast 2714MB
[task 2024-02-03T05:39:12.526Z] 05:39:12     INFO - TEST-OK | browser/base/content/test/tabs/browser_window_open_modifiers.js | took 122601ms

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:arai, since you are the author of the regressor, bug 1877019, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Tooru Fujisawa [:arai]]

the test is taking ~2 minutes in that configuration.
given the default timeout is 60 seconds (am I correct?), adding requestLongerTimeout(3); would solve

Comment 3

[Tooru Fujisawa [:arai]]

actually it takes 3 minutes on osx debug TV.
The test is known to take long given it opens many windows, and opening windows takes long on some configuration
also I don't think splitting the test only for TV makes much sense,
so I'll add requestLongerTimeout(4);.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1877019

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1878462 - Set longer timeout for browser_window_open_modifiers.js. r?smaug!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a4c06f1970f
Set longer timeout for browser_window_open_modifiers.js. r=smaug

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8a4c06f1970f

Comment 8

[Intermittent Failures Robot]

3 failures in 3952 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1878462&startday=2024-01-29&endday=2024-02-04&tree=all

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1878462 - Set longer timeout for browser_window_open_modifiers.js. r?smaug!

Original Revision: https://phabricator.services.mozilla.com/D200561

Comment 10

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• User impact if declined: regression fix for D200622
• Fix verified in Nightly: yes
• Risk associated with taking this patch: low
• Steps to reproduce for manual QE testing: None
• Is Android affected?: no
• String changes made/needed: None
• Needs manual QE test: no
• Explanation of risk level: This is test-only change to mitigate the timeout caused by slow configuration