1878629 - Consider removing nsIEventListenerService.addSystemEventListener/removeSystemEventListener

Status: RESOLVED FIXED

(Core :: DOM: Events, task)

Description

[Gregory Pappas [:gregp]]

We have two ways of adding system group event listeners:

• nsIEventListenerService.addSystemEventListener

  Services.els.addSystemEventListener(document, "mouseup", listener, true);
  

• mozSystemGroup in EventListenerOptions

  document.addEventListener("mouseup", listener, { capture: true, mozSystemGroup: true });
  

Do we need both?

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I think we don't need both and the one in nsIEventListenerService was added when addEventListener didn't yet take a dictionary as param.

Comment 2

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 1: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (browser/)

Comment 3

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 2: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (devtools/)

Depends on D201043

Comment 4

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 3: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (dom/)

Depends on D201044

Comment 5

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 4: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (editor/)

Depends on D201045

Comment 6

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 5: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (layout/)

Depends on D201046

Comment 7

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 6: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (toolkit/)

Depends on D201047

Comment 8

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 7: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (widget/)

Depends on D201048

Comment 9

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 8: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService in Eventutils

Depends on D201049

Comment 10

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 9: Remove SpecialPowers.addSystemEventListener and SpecialPowers.removeSystemEventListener

Depends on D201050

Comment 11

[Gregory Pappas [:gregp]]

Attachment: Bug 1878629 - part 10: Remove nsIEventListenerService.addSystemEventListener and nsIEventListenerService.removeSystemEventListener

Depends on D201051

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f0e7412b97d
part 1: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (browser/) r=tabbrowser-reviewers,Gijs,dao
https://hg.mozilla.org/integration/autoland/rev/226dd896d3b1
part 2: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (devtools/) r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/2e13b7aa672f
part 3: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (dom/) r=masayuki
https://hg.mozilla.org/integration/autoland/rev/75bcf40d126c
part 4: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (editor/) r=masayuki
https://hg.mozilla.org/integration/autoland/rev/27247af6f2ae
part 5: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (layout/) r=masayuki
https://hg.mozilla.org/integration/autoland/rev/50704d1797c7
part 6: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (toolkit/) r=credential-management-reviewers,reusable-components-reviewers,Gijs,hjones,sgalich
https://hg.mozilla.org/integration/autoland/rev/9e21f02eb384
part 7: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (widget/) r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b0b8f0e9417b
part 8: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService in Eventutils r=smaug
https://hg.mozilla.org/integration/autoland/rev/544a093d1101
part 9: Remove SpecialPowers.addSystemEventListener and SpecialPowers.removeSystemEventListener r=smaug
https://hg.mozilla.org/integration/autoland/rev/d5fef403c297
part 10: Remove nsIEventListenerService.addSystemEventListener and nsIEventListenerService.removeSystemEventListener r=smaug

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7f0e7412b97d
https://hg.mozilla.org/mozilla-central/rev/226dd896d3b1
https://hg.mozilla.org/mozilla-central/rev/2e13b7aa672f
https://hg.mozilla.org/mozilla-central/rev/75bcf40d126c
https://hg.mozilla.org/mozilla-central/rev/27247af6f2ae
https://hg.mozilla.org/mozilla-central/rev/50704d1797c7
https://hg.mozilla.org/mozilla-central/rev/9e21f02eb384
https://hg.mozilla.org/mozilla-central/rev/b0b8f0e9417b
https://hg.mozilla.org/mozilla-central/rev/544a093d1101
https://hg.mozilla.org/mozilla-central/rev/d5fef403c297