1878698 - Text selection is hidden by line highlighting

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the debugger and open a file
2. Try to select text on a single line

Expected results

I can see that the text is selected

Actual results

The line gets highlighted, and I can't see the text selection until the highlight is gone

---

In 122, clicking on a line doesn't cause it to be highlighted, we should probably revert to this behavior

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834727

:ochameau, since you are the author of the regressor, bug 1834727, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1878698 - [devtools] Avoid highlighting the location on cursor changes.

We have to avoid trigerring the select location action as it will force the highlighting
of the current line and dismiss/hide the user selected range.

Comment 3

[Pascal Chevrel:pascalc]

Alexandre, could you put a severity obn this? Are you planning an uplift to 123? Thanks

Comment 4

[Pascal Chevrel:pascalc]

Last beta is tomorrow, wontfix 123.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834727

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e60ae336758
[devtools] Avoid highlighting the location on cursor changes. r=devtools-reviewers,nchevobbe

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9e60ae336758

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 9378404 [details]
Bug 1878698 - [devtools] Avoid highlighting the location on cursor changes.

Beta/Release Uplift Approval Request

• User impact if declined: When selecting any line of code in the debugger, the line would be highlighted and may confuse the user.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Click any line via the mouse in a JS file in the debugger.
  The cursor location is updated in the footer, but the line is not highlighted with a yellow background.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9378404 [details]
Bug 1878698 - [devtools] Avoid highlighting the location on cursor changes.

Approved for 124.0b4

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c92925238b7