Closed Bug 1878701 Opened 1 year ago Closed 1 year ago

DLP UX feedback - busy dialog

Categories

(Firefox :: Data Loss Prevention, enhancement)

Product:
Firefox
Component:
Data Loss Prevention
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: gstoll, Assigned: gstoll)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Bug 1878701 - Part 1: move spinner in DLP agent busy dialog next to the title r=handyman,gijs
48 bytes, text/x-phabricator-request
Details | Review
Bug 1878701 - Part 2: Make DLP busy dialog have a gray Cancel button r=handyman,gijs
48 bytes, text/x-phabricator-request
Details | Review
Bug 1878701 - Part 3: Use UX-suggested text for the DLP agent busy dialog r=handyman
48 bytes, text/x-phabricator-request
Details | Review
What the DLP busy dialog looks like after these patches
98.88 KB, image/png
Details
  • move progress icon next to the header
  • make Cancel use secondary (gray) button style
  • update text
Blocks: 1871166
Assignee: nobody → gstoll
Status: NEW → ASSIGNED

The UX suggestion was to move the busy spinner next to the title, and it
turns out there's already a way to set an icon in the CommonDialog, so
use that and remove the special case spinner code.

This changes CommonDialog to allow having a button 1 (which is styled
like Cancel) without a button 0. (which is styled like OK)

Pushed by gstoll@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2db4b9283ba5 Part 1: move spinner in DLP agent busy dialog next to the title r=handyman,Gijs https://hg.mozilla.org/integration/autoland/rev/675a4ee7708c Part 2: Make DLP busy dialog have a gray Cancel button r=handyman,Gijs https://hg.mozilla.org/integration/autoland/rev/2e05063bf9de Part 3: Use UX-suggested text for the DLP agent busy dialog r=handyman,fluent-reviewers,bolsson

Backed out for causing remote failures in browser_javascriptDialog_alert.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | remote/cdp/test/browser/page/browser_javascriptDialog_alert.js | Test timed out -
    TEST-UNEXPECTED-FAIL | remote/shared/listeners/test/browser/browser_PromptListener.js | Test timed out -

And wd: https://treeherder.mozilla.org/logviewer?job_id=447302212&repo=autoland
And Mn: https://treeherder.mozilla.org/logviewer?job_id=447303079&repo=autoland

Flags: needinfo?(gstoll)
Flags: needinfo?(gstoll)

These were caused because various tests were dismissing dialogs by "clicking" Cancel, even if that button was hidden. With my change the button is now disabled so that leads to test timeouts, etc.

I have a fix for the tests that failed - running a try build and I'm going to run the changes by :gijs or someone to make sure we think we're doing the right thing. (definitely not going to land during soft code freeze :-) )

Pushed by gstoll@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f36ae2913e8d Part 1: move spinner in DLP agent busy dialog next to the title r=handyman,Gijs https://hg.mozilla.org/integration/autoland/rev/b3673d37b3ac Part 2: Make DLP busy dialog have a gray Cancel button r=handyman,Gijs,reusable-components-reviewers,mstriemer https://hg.mozilla.org/integration/autoland/rev/10b12ac6e370 Part 3: Use UX-suggested text for the DLP agent busy dialog r=handyman,fluent-reviewers,bolsson
Regressions: 1935401
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: