1878749 - Request to change sec-approval request form

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Donal Meehan [:dmeehan]]

Other Requests

Request to change sec-approval request form.

There is a form of questions added when ? is selected in a sec-approval flag on an attachment.

Please modify the questions as follows:

1. Change "Which older supported branches are affected by this flaw?" to "Which branches (beta, release, and/or ESR) are affected by this flaw, and do the release status flags reflect this affected/unaffected state correctly?"
2. Add "Is the patch ready to land after security approval is given?" before "Is Android affected?:"

Comment 1

[David Lawrence [:dkl]]

Updated

Comment 2

[Donal Meehan [:dmeehan]]

:dkl is this change done on the Administration settings, or is it a code change?
i.e. should we expect the changes to be live now or will it be live the next time you push an update?
For example the form here doesn't include the changes requested.

Comment 3

[David Lawrence [:dkl]]

(In reply to Donal Meehan [:dmeehan] from comment #2)

:dkl is this change done on the Administration settings, or is it a code change?
i.e. should we expect the changes to be live now or will it be live the next time you push an update?
For example the form here doesn't include the changes requested.

Sorry for not being clear. It was just an admin change and did not require code change. So the new version should have been visible immediately. I will look at why the bug mentioned in comment 2 did not have the correct text.

Comment 4

[Donal Meehan [:dmeehan]]

Thanks, I had expected it to be live when you made the changes.
I thought it was on the Admin side, but I wanted to double-check when I saw the form didn't include the changes.
I can double-check again once you have investigated and this is resolved. Hopefully, it's an easy fix.

Comment 5

[David Lawrence [:dkl]]

(In reply to Donal Meehan [:dmeehan] from comment #4)

Thanks, I had expected it to be live when you made the changes.
I thought it was on the Admin side, but I wanted to double-check when I saw the form didn't include the changes.
I can double-check again once you have investigated and this is resolved. Hopefully, it's an easy fix.

My bad. Yes this will need a code change and deployment which I can do right away. We had text left over from the old way of doing custom comment text for sec-approval flags and I thought that was the one to be edited.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1878749 - Request to change sec-approval request form (#2189)

Comment 7

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/31f779516cd14dbcb7726f4d958a81944235ef8f