Closed Bug 1878758 Opened 4 months ago Closed 4 months ago

The serialization of transition property should follow shortest serialization principle

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: boris, Assigned: boris)

References

()

Details

Attachments

(1 file)

Per https://github.com/web-platform-tests/wpt/issues/43574, we should follow the shortest serialization principle for transition shorthand.

Per https://github.com/web-platform-tests/wpt/issues/43574, we should
follow the shortest serialization principle for transition shorthand.

Attachment #9378397 - Attachment description: Bug 1805727 - Part 3: Follow shortest serialization principle for transition shorthand. → Bug 1878758 - Follow shortest serialization principle for transition shorthand.
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edd89a13946a
Follow shortest serialization principle for transition shorthand. r=zrhoffman
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44430 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Upstream PR merged by moz-wptsync-bot

FWIW this seems to have caused site breakage on pages like:
https://www.pinko.com/en-us/two-tone-platform-sneakers-SS0007P001YH700403.html

In Firefox (and Safari), the site throws an Uncaught TypeError at load time:

Uncaught TypeError: t.indexOf is not a function

for: https://www.pinko.com/on/demandware.static/Sites-pinko-us-Site/-/en_US/v1714430179241/js/main.js

This is because for some reason the site is manually parsing the computed value of transition on some element, and their code doesn't gracefully handle the possibility that the transition-delay might just be missing from the serialized value, so they end up working with undefined as if it were a string.

More details in https://github.com/webcompat/web-bugs/issues/136217 .

Probably not something that we in-particular need to worry about, since all browsers are changing behavior; but for the moment this is something that works in Chrome but not in Firefox/Safari (though dbaron said he thinks Chrome folks are willing to align on this, so hopefully that Chrome change is coming).

More details in https://github.com/webcompat/web-bugs/issues/136217

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: