1878804 - Implement Wasm-friendly overload of setBindGroup

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement, P3)

Description

[Jim Blandy :jimb]

As described in emscripten#21221, the spec gives setBindGen an overload that allows it to draw dynamic offset values from a subset of a UInt32Array. This is an appealing binding for WebAssembly programs to use, as they can simply pass their entire memory object as the UInt32Array, indicating the range of their address space that holds the dynamic offsets via the offset and length arguments.

Obviously, since it's in the spec, Firefox will implement this overload. I'm mostly filing this bug to record the connection with the emscripten issue.

Comment 1

[Andy Leiserson [:aleiserson]]

Our current behavior (without this overload implemented) is to interpret the dynamicOffsetsData argument in its entirety as an iterable of dynamic offsets, which besides being incorrect, is quite slow.

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: WIP: Bug 1878804 - refactor(webgpu)!: expose data/start/length overload of `GPUBindingCommandsMixin.setBindGroup` r=#webgpu-reviewers!

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

:aleiserson: I provided the patch I've already had for a few months here. Feel free to commandeer it!

Comment 4

[Andy Leiserson [:aleiserson]]

Attachment: Bug 1878804 - Implement the 5-argument overload of setBindGroup r=#webgpu-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f06eff19718
Implement the 5-argument overload of setBindGroup r=webgpu-reviewers,ErichDonGubler,webidl,smaug

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8f06eff19718