Closed Bug 1878841 Opened 2 years ago Closed 2 years ago

Add testing for connection idle maintenance

Tracking

()

Status:

RESOLVED FIXED

Milestone:

125 Branch

Tracking Flags:

Tracking

Status

firefox125

---

fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(4 external files)

Bug 1878841 - Add basic testing for connection idle maintenance; r=#dom-storage 2 years ago Jan Varga [:janv] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1878841 - Fix madeProgress check in DatabaseConnection::ReclaimFreePagesWhileIdle; r=#dom-storage 2 years ago Jan Varga [:janv] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1878841 - Add support for pausing IndexedDB connection thread during connection idle maintenance; r=#dom-storage 2 years ago Jan Varga [:janv] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1878841 - Add testing for stopping of connection idle maintenance; r=#dom-storage 2 years ago Jan Varga [:janv] 48 bytes, text/x-phabricator-request		Details \| Review

Jan Varga [:janv]

Assignee

Description

•

2 years ago

•

Edited

There's now test_idle_maintenance.js, but that is only testing the overall maintenance of all available databases on disk (triggered by the idle-daily message). Bug 1791767 needs to do some changes which affect the connection idle maintenance (done after 2 seconds of inactivity on an open connection), so it would be better to have some testing coverage even though there can be some risk of initial intermittent failures due to dependency on timeouts.

Jan Varga [:janv]

Assignee

Comment 1

•

2 years ago

Attached file Bug 1878841 - Add basic testing for connection idle maintenance; r=#dom-storage — Details

Jan Varga [:janv]

Assignee

Comment 2

•

2 years ago

Attached file Bug 1878841 - Fix madeProgress check in DatabaseConnection::ReclaimFreePagesWhileIdle; r=#dom-storage — Details

The warn only check is supposed to mach the debug only assertion, but it
is actually not in line with the assertion causing a lot of warnings during
test_connection_idle_maintenance.js execution.

Jan Varga [:janv]

Assignee

Comment 3

•

2 years ago

Attached file Bug 1878841 - Add support for pausing IndexedDB connection thread during connection idle maintenance; r=#dom-storage — Details

Jan Varga [:janv]

Assignee

Comment 4

•

2 years ago

Attached file Bug 1878841 - Add testing for stopping of connection idle maintenance; r=#dom-storage — Details

Jan Varga [:janv]

Assignee

Updated

•

2 years ago

Blocks: 1879493

Pulsebot

Comment 5

•

2 years ago

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f22be1e1752b Add basic testing for connection idle maintenance; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/40a429fa8f49 Fix madeProgress check in DatabaseConnection::ReclaimFreePagesWhileIdle; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/4001ea4b11b0 Add support for pausing IndexedDB connection thread during connection idle maintenance; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/6dd4ac119065 Add testing for stopping of connection idle maintenance; r=dom-storage-reviewers,jari

Iulian Moraru

Comment 6

•

2 years ago

Backed out for causing xpcshell failures on test_connection_idle_maintenance.js.
So far, this only happened on Android 7.0 x86-64.

[task 2024-02-27T18:13:09.429Z] 18:13:09     INFO -  TEST-START | xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js
[task 2024-02-27T18:13:09.471Z] 18:13:09     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DEVELOPER_OBJ_DIR=/builds/worker/workspace/obj-build --es env6 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env7 MOZ_FETCHES_DIR=/builds/worker/fetches --es env8 MOZ_DISABLE_SOCKET_PROCESS=1 --es env9 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env10 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env11 GRE_HOME=/data/local/tmp/test_root/xpcb --es env12 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/6d06c261-b335-4bb4-b1bb-bef00c15a245 --es env13 HOME=/data/local/tmp/test_root/xpc/p --es env14 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/d2833671-2498-4f00-bd20-c165018d2375 --es env15 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env16 MOZ_IN_AUTOMATION=1 --es env17 MOZ_ANDROID_CPU_ABI=x86_64 --es env18 MOZHTTP2_PORT=39833 --es env19 MOZNODE_EXEC_PORT=33675 --es env20 MOZHTTP3_ECH= --es env21 TMPDIR=/data/local/tmp/test_root/xpc/p/6d06c261-b335-4bb4-b1bb-bef00c15a245 --es env22 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/6d06c261-b335-4bb4-b1bb-bef00c15a245 --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/6d06c261-b335-4bb4-b1bb-bef00c15a245/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/dom/indexedDB/test/unit/xpcshell-head-parent-process.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/dom/indexedDB/test/unit";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_connection_idle_maintenance.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --ez use_multiprocess True --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-b9402a86-b406-4c64-9112-6f63c8733274.log
[task 2024-02-27T18:13:09.690Z] 18:13:09     INFO -  remotexpcshelltests.py | xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js | 28809 | Launched Test App
[task 2024-02-27T18:13:27.162Z] 18:13:27     INFO -  remotexpcshelltests.py | xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js | 28809 | Application ran for: 0:00:17.732266
[task 2024-02-27T18:13:27.224Z] 18:13:27  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js | xpcshell return code: 0
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  TEST-INFO took 17794ms
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  >>>>>>>
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  TEST-PASS | xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js | this.runTest - [this.runTest : 52] There should be a testSteps function - true == true
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  running event loop
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js | Starting testSteps
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  (xpcshell/head.js) | test testSteps pending (2)
[task 2024-02-27T18:13:27.224Z] 18:13:27     INFO -  "Creating database"
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  "Getting database usage before maintenance"
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  "Waiting for maintenance to start"
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  "Waiting for maintenance to finish"
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  "Getting database usage after maintenance"
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  "Database usage before: 37016. Database usage after: 26624"
[task 2024-02-27T18:13:27.225Z] 18:13:27  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.toml:dom/indexedDB/test/unit/test_connection_idle_maintenance.js | testSteps - [testSteps : 84] Maintenance significantly decreased database usage - false == true
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  test_connection_idle_maintenance.js:testSteps:84
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  /data/local/tmp/test_root/xpc/head.js:_do_main:245
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  /data/local/tmp/test_root/xpc/head.js:_execute_test:596
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  -e:null:1
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  exiting test
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  _abort_failed_test@/data/local/tmp/test_root/xpc/head.js:869:20
[task 2024-02-27T18:13:27.225Z] 18:13:27     INFO -  do_report_result@/data/local/tmp/test_root/xpc/head.js:981:5
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  Assert<@/data/local/tmp/test_root/xpc/head.js:70:21
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  Assert.prototype.ok@resource://testing-common/Assert.sys.mjs:277:10
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  testSteps@test_connection_idle_maintenance.js:84:5
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  _do_main@/data/local/tmp/test_root/xpc/head.js:245:6
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  _execute_test@/data/local/tmp/test_root/xpc/head.js:596:5
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  @-e:1:1
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  exiting test
[task 2024-02-27T18:13:27.226Z] 18:13:27     INFO -  <<<<<<<
[task 2024-02-27T18:13:27.297Z] 18:13:27     INFO -  Cleaning up profile for /builds/worker/workspace/build/tests/xpcshell/tests/dom/indexedDB/test/unit/test_connection_idle_maintenance.js folder: /data/local/tmp/test_root/xpc/p/6d06c261-b335-4bb4-b1bb-bef00c15a245
[task 2024-02-27T18:13:27.486Z] 18:13:27     INFO -  TEST-START | netwerk/test/unit/test_altsvc_http3.js

Flags: needinfo?(jvarga)

Jan Varga [:janv]

Assignee

Comment 7

•

2 years ago

Yeah, I just found out the new tests can't work on Android. Unfortunately, try auto didn't catch that earlier.

Flags: needinfo?(jvarga)

Iulian Moraru

Comment 8

•

2 years ago

•

Edited

FYI: much later this TV job failed. I see that is for a test that you just added.

Sorry, Ignore this, I got confused for a second. This is the same failure as the tier 1 jobs that I made the backout for.

Pulsebot

Comment 9

•

2 years ago

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27a282527a8f Add basic testing for connection idle maintenance; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/7ec724ee3aa7 Fix madeProgress check in DatabaseConnection::ReclaimFreePagesWhileIdle; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/5832b428eaea Add support for pausing IndexedDB connection thread during connection idle maintenance; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/06645f775e47 Add testing for stopping of connection idle maintenance; r=dom-storage-reviewers,jari

Natalia Csoregi [:nataliaCs]

Comment 10

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/27a282527a8f
https://hg.mozilla.org/mozilla-central/rev/7ec724ee3aa7
https://hg.mozilla.org/mozilla-central/rev/5832b428eaea
https://hg.mozilla.org/mozilla-central/rev/06645f775e47

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox125: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 125 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Add testing for connection idle maintenance

Categories

(Core :: Storage: IndexedDB, task, P2)

Tracking

()

People

(Reporter: janv, Assigned: janv)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(4 external files)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Updated

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Attachment

General

Description

File Name

Content Type