1878920 - Tab preview displayed when dragging a tab in the tab strip

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screencast showing the issue

Found in

• Latest Nightly 124.0a1

Affected versions

• Latest Nightly 124.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13.6
• Unaffected platforms: Ubuntu 22.04

Preconditions

• Activate the feature by setting browser.tabs.cardPreview.enabled as true in about:config

Steps to reproduce

1. Have 3 or more websites opened
2. Grab one of the tabs and drag it through the tab strip

Expected result

• Not sure which is the desired expected result here but I think the preview should be hidden when the tab is moving. This is the behaviour in other browsers with their preview (Chrome, Vivaldi). We already have a preview of the page when we are dragging a tab.

Actual result

• The tab preview appears and is displayed until one lands the tab in the tab strip.

Regression range

• Not a regression since this is reproducible on old Nightly build from 2024-01-13 where this feature officially landed, although the preview did not move with the tab but it was still visible.

Additional notes

• For some reason this does not reproduce in Ubuntu 22.04.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:bmaris, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[DJ (:dwalker)]

Attachment: Bug 1878920 - disable preview when dragging a tab. r?#tabbrowser-reviewers

Comment 3

[Chris Peterson [:cpeterson]]

This bug can prevent users from dragging a tab into a folder on the bookmarks bar that is blocked by the preview card.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0b3ccacd876
disable preview when dragging a tab. r=tabbrowser-reviewers,desktop-theme-reviewers,cmkm,mak

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a0b3ccacd876

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dwalker, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Looks like this is fixed now using latest Nightly 128.0a1 across platforms (macOS 13, Windows 11 and Ubuntu 22.04).

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.