1879001 - Attr-associated element still returned when content attribute is reset

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[James Teh [:Jamie]]

Test case:

data:text/html,
<button id="toggle">toggle</button>
<div id="pop" popover>pop</div>
<script>
toggle.popoverTargetElement = pop;
toggle.setAttribute("popovertarget", "invalid");
alert(toggle.popoverTargetElement);
</script>

STR:

1. Open the test case above.
   • Expected: The alert should say "null"
   • Actual: The alert says "[object HTMLDivElement]"

From the spec:

For element reflected targets only: the following attribute change steps, given element, localName, oldValue, value, and namespace, are used to synchronize between the content attribute and the IDL attribute:

1. If localName is not attr or namespace is not null, then return.
2. Set element's explicitly set attr-element to null.

Unless I'm missing something, it seems we're just not doing these attribute change steps.

Comment 1

[James Teh [:Jamie]]

Removing the attribute also fails to clear the explicitly set attr-element:

data:text/html,
<button id="toggle">toggle</button>
<div id="pop" popover>pop</div>
<script>
toggle.popoverTargetElement = pop;
toggle.removeAttribute("popovertarget");
alert(toggle.popoverTargetElement);
</script>

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

zsun, can you, please, take a look?

Comment 3

[zsun]

Attachment: Bug 1879001 - Remove the popovertarget attribute or set it to an invalid value should clear the explicitly set attr-element. r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0ebcced75f
Remove the popovertarget attribute or set it to an invalid value should clear the explicitly set attr-element. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44634 for changes under testing/web-platform/tests

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6f0ebcced75f

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot