1879010 - Initial attempt to implement lazy tiering for wasm

Status: RESOLVED DUPLICATE of bug 1891182

(Core :: JavaScript: WebAssembly, enhancement, P1)

Description

[Julian Seward [:jseward]]

Make a first attempt to implement lazy tiering for wasm.

Comment 1

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-5

A backup of WIP; is not good for anything right now.

Comment 2

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-8

Can run BaselineCompileFunctions on functions in parallel.
The resulting code and metadata is not yet collected up, though.

Comment 3

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-10

Can run BaselineCompileFunctions on functions in parallel.
The resulting metadata is stashed in XCode.

Comment 4

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-12

Can complete new WebAssembly.Module(..) for
jit-test/tests/wasm/bench/wasm_box2d.wasm (baseline compilation only).
I'm sure the resulting code is not runnable though.

Comment 5

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-17

Can baseline-compile, instantiate and run the simple test case attached in
comment 6. Patch applies against m-c 691891:16becc119397.

Comment 6

[Julian Seward [:jseward]]

Attachment: badness134.js

A simple test case for the patch in comment 5. Run with:
./dist/bin/js --wasm-compiler=baseline --no-ion badness134.js.

Comment 7

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-21

The patch gradually comes to life. On x86_64-linux, this passes all 147
wasm/gc tests:

../src/jit-test/jit_test.py --args="--wasm-compiler=baseline --no-ion" \
                            -no-xdr -f ./dist/bin/js wasm/gc

and about 3200 of the circa 4000 wasm/ tests. Still baseline-only at this
point.

Comment 8

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-23

Revised patch, still baseline only. Passes 3472 tests, fails 281. Anything
involving debugging, profiling, disassembly, explicit tiering, and probably a
bunch of other stuff, is still broken.
Applies against m-c 691891:16becc119397.

Comment 9

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-27

With:

• a top level summary of changes (top of WasmTopLevel.cpp)
• initial work for debug-mode incremental tiering up
• major rework/clarification of fmFinishModule
• baseline compilation is really done in parallel now (bug fix)

Comment 10

[Julian Seward [:jseward]]

Attachment: bug1879010-new-toplevel.diff-32

Final patch; this line of patches has been abandoned in favour of a more
incremental approach.

Comment 11

[Ryan Hunt [:rhunt]]

As Julian noted, we're going with a more incremental approach that was started in bug 1891182.