1879102 - Free Highlight element is highlighted incorrectly after being selected and rotating the PDF

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Dana Lucaci, Desktop QA]

Attachment: Screenshot 2024-02-07 at 16.55.43.png

Found in

• Nightly 124.0a1 (2024-02-07)

Affected versions

• Nightly 124.0a1 (2024-02-07)

Tested platforms

• Affected platforms: All

Preconditions

• Have a PDF opened in Firefox

Steps to reproduce

1. Enable the Highlight tool.
2. Free Highlight over the PDF.
3. Rotate the PDF.
4. Click over the added highlight.

Expected result

• The focus frame is correctly displayed.

Actual result

• The focus frame is cut off.

Regression range
Not a Regression

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dlucaci, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Calixte Denizet (:calixte)]

The mask used to not render the inside of the shape must be rotated correctly.

Comment 3

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Correctly rotate the mask when rotation a free highlight (bug 1879102) (#17639)

Comment 4

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 124.0a1 (2024-02-17)