1879107 - The Small and Large Thickness DOTS from the PDF Highlights tool submenu are not visible with HCM

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2024-02-07_16h44_31.png

Found in

• Nightly 124.0a1 (2024-02-07)

Affected versions

• Nightly 124.0a1 (2024-02-07)

Affected platforms

• Windows

Preconditions:
Enable High Contrast mode.

Steps to reproduce

1. Open any PDF in Firefox.
2. Enable the Highlight tool.

Expected result

• The Small and Large Dot for the Thickness levels should be visible with High Contrast

Actual result

• The Small and Large Dot for the Thickness levels are not visible with High Contrast

Regression range
Not a Regression

Please note that I'm not entirely sure that those two Thickness Dots should be visible with High Contrast mode, please close the issue if its invalid.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Nathan LaPré]

Marking this an access-s3 since there is an implied "left is smaller, right is larger," but it's arguably an access-s2 because the contrast is so poor. Here is the relevant Figma file that shows how this was designed.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:calixte, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Calixte Denizet (:calixte)]

In the Figma, the color is HCM/Win 10 - High Contrast White/Selected Text, hence I set the color to HighlightText (which should be used for selected text according to https://drafts.csswg.org/css-color/#css-system-colors).
More likely we should use CanvasText here.

Comment 5

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Set the right color to size samples in the highlight thickness panelwhen in HCM (bug 1879107) (#17638)

Comment 6

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 124.0a1 (2024-02-17).