1879130 - Enable Report Broken Site in the prefs by default, with "reason" drop-down required

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Thomas Wisniewski [:twisniewski]]

As we want to ship the feature in 123, we should make sure the prefs are set appropriately before it's too late (and we have to flip the prefs some other way).

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1879130 - enable Report Broken Site by default, with 'reason' drop-down required; r?ksenia

Comment 2

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9378795 [details]
Bug 1879130 - enable Report Broken Site by default, with 'reason' drop-down required; r?ksenia

Beta/Release Uplift Approval Request

• User impact if declined: Negligible. We will have to ship these pref-flips outside of the build itself.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just flipping prefs which we have already experimented with on release and beta.
• String changes made/needed:
• Is Android affected?: No

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4190a8a3805b
enable Report Broken Site by default, with 'reason' drop-down required; r=ksenia

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_keyboard_navigation.js

• backout: https://hg.mozilla.org/integration/autoland/rev/e23dca87bd3f2cca14bcd62b6986cde23210d465
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Pno2y5iwSGiTSKjW4zO3Zw.0&revision=4190a8a3805bb29b7694a7b2e6994a0c19ff39c5
• failure log: https://treeherder.mozilla.org/logviewer?job_id=446396185&repo=autoland&lineNumber=5640

[task 2024-02-07T19:04:18.795Z] 19:04:18     INFO - TEST-PASS | browser/components/reportbrokensite/test/browser/browser_keyboard_navigation.js | AppMenu menu item is enabled - 
[task 2024-02-07T19:04:18.795Z] 19:04:18     INFO - Console message: [JavaScript Warning: "WebGL context was lost." {file: "resource://gre/actors/ReportBrokenSiteParent.sys.mjs" line: 95}]
[task 2024-02-07T19:04:18.796Z] 19:04:18     INFO - Console message: [JavaScript Warning: "WebGL context was lost." {file: "resource://gre/actors/ReportBrokenSiteParent.sys.mjs" line: 95}]
[task 2024-02-07T19:04:18.796Z] 19:04:18     INFO - Console message: [JavaScript Warning: "onmozfullscreenchange is deprecated." {file: "https://example.com/" line: 0}]
[task 2024-02-07T19:04:18.797Z] 19:04:18     INFO - Console message: [JavaScript Warning: "onmozfullscreenerror is deprecated." {file: "https://example.com/" line: 0}]
[task 2024-02-07T19:04:18.797Z] 19:04:18     INFO - Buffered messages logged at 19:03:33
[task 2024-02-07T19:04:18.798Z] 19:04:18     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2024-02-07T19:04:18.798Z] 19:04:18     INFO - Buffered messages finished
[task 2024-02-07T19:04:18.799Z] 19:04:18     INFO - TEST-UNEXPECTED-FAIL | browser/components/reportbrokensite/test/browser/browser_keyboard_navigation.js | Test timed out - 
[task 2024-02-07T19:04:18.799Z] 19:04:18     INFO - GECKO(9134) | Completed ShutdownLeaks collections in process 9134

Comment 5

[Thomas Wisniewski [:twisniewski]]

How odd that this didn't trip in my local testing earlier! It does now, so at least it was just a "me" problem. It's a trivial fix, I'll update the patch and reland ASAP.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84ab6fd1af28
enable Report Broken Site by default, with 'reason' drop-down required; r=ksenia

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b492cccd574
Backed out changeset 4190a8a3805b for causing failures on browser_keyboard_navigation.js CLOSED TREE

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b492cccd574
Backed out changeset 4190a8a3805b for causing failures on
browser_keyboard_navigation.js CLOSED TREE

Hi Thomas, it seems that the bot got itself in a bit of a twist.

The backout (In reply to Pulsebot from comment #7) is the one done in comment #4.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/84ab6fd1af28

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9378795 [details]
Bug 1879130 - enable Report Broken Site by default, with 'reason' drop-down required; r?ksenia

Approved for 123 beta 9, thanks.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/34dc7189ce45

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/34dc7189ce45