1879181 - Add enable and disable URL lists for DLP

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, task)

Description

[Greg Stoll :gstoll]

There should two preferences:

• An enable list of regular expression-like strings that indicate if the browser is at this URL it needs to check for DLP
• A disable list of regular expression-like strings that indicate if the browser is at this URL it does not need to check for DLP

If a URL matches neither enable nor disable, do not check for DLP. If a URL matches both enable and disable, do not check for DLP.

Note that for performance reasons this should be applied before Firefox does any extra DLP-related work like calculating a file hash or printing a PDF version of a document.

Comment 1

[David Parks [:handyman]]

This case creates a new condition -- we would normally return a ContentAnalysisResponse here, and we can still do that but then we need to also make sure that the Acknowledge isn't sent to the agent (which is easy for auto-acknowledge). Otherwise we would want to return an "error" like we do with the cancel button.

Comment 2

[David Parks [:handyman]]

Attachment: Bug 1879181: Allow skipping content analysis for requests that match url list r=gstoll!

Check the URLs in the request against the prefs
browser.contentanalysis.allow_url_regex_list and
browser.contentanalysis.deny_url_regex_list, which are space-separated
lists of ECMAscript regexs that match against ASCII-encoded URLs.

Comment 3

[David Parks [:handyman]]

Attachment: Bug 1879181: Unit test ContentAnalysis URL filter lists r=gstoll!

Would be nice to check all of AnalyzeContentRequest but proper CA unit tests
are still wip.

Depends on D203508

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25521d09c1de
Allow skipping content analysis for requests that match url list r=gstoll,win-reviewers
https://hg.mozilla.org/integration/autoland/rev/78303b2900e9
Unit test ContentAnalysis URL filter lists r=gstoll
https://hg.mozilla.org/integration/autoland/rev/b2407a14159f
apply code formatting via Lando

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e891ca1ff7cb
Backed out 3 changesets for causing gtest failures on ContentAnalysisTest.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out 3 changesets for causing gtest failures on ContentAnalysisTest.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=IwL9RSIORkmbUJ9qbxdrmw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=b2407a14159fedc9da341a9ed4274b8749e1d543

Failure log: https://treeherder.mozilla.org/logviewer?job_id=450127124&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e891ca1ff7cb

Comment 7

[David Parks [:handyman]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&selectedTaskRun=J2Y3uHn-TZKgJc0ufiBXPA.0&revision=85949d784e481ee073e466b9008b2a3b83323a42

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe880c75c428
Allow skipping content analysis for requests that match url list r=gstoll,win-reviewers
https://hg.mozilla.org/integration/autoland/rev/1617e8ac8baa
Unit test ContentAnalysis URL filter lists r=gstoll

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fe880c75c428
https://hg.mozilla.org/mozilla-central/rev/1617e8ac8baa