1879318 - Store custom property references in a list rather than a set.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez (:emilio)]

The idea is that this will allow speeding up substitution by avoiding re-tokenization.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1879318 - Store custom property references in a list. r=dshin,zrhoffman,#style

This is a preliminary patch to keep all references (even duplicates), in
order to speed up substitution by avoiding re-tokenizing.

The assumption is that referencing the same variable multiple times
on the declaration is not common, and thus it's not a big deal to
optimize for that.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: WIP: Bug 1879318 - Simplify custom property substitution.

This should speed up custom variable substitution to avoid re-tokenizing
etc.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=bc6cc20d3045494604396a2ee5e4eea840b4ff1b&newProject=try&newRevision=7a96609b47d24ceb721650dbfc008a1130ba6453&page=1&framework=13

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/842672970113
Store custom property references in a list. r=zrhoffman,firefox-style-system-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/842672970113

Comment 6

[Phabricator Automation]

Comment on attachment 9379036 [details]
WIP: Bug 1879318 - Simplify custom property substitution.

Revision D201116 was moved to bug 1879743. Setting attachment 9379036 [details] to obsolete.