1879354 - The Keep Closed ? message is not respecting the High Contrast mode standards

Status: VERIFIED FIXED

(Firefox :: Shopping, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: HCM.mp4

Found in

• Nightly 124.0a1 (2024-02-08)

Affected versions

• Nightly 124.0a1 (2024-02-08)
• Beta 123.0b8

Affected platforms

• windows

Preconditions:
browser.shopping.experience2023.enabled, set to true (doubleclick)
browser.shopping.experience2023.optedIn, set to 1 (doubleclick, input ‘0’, hit enter)
browser.shopping.experience2023.autoOpen.enabled - true
browser.shopping.experience2023.autoOpen.userEnabled - true

Steps to reproduce

1. Reach https://www.amazon.com/CubiCubi-Computer-Writing-Office-Industrial/dp/B084VHPPTC/ref=sr_1_2_sspa?keywords=desk&qid=1707405640&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&psc=1
2. Close And Reopen the Review Checker from the Address bar icon only 5 times.

Expected result

• The Keep Closed ? message should respect the HCM standards similar with the rest of the sidebar.

Actual result

• The Keep Closed ? message is not respecting the High Contrast standards

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[kpatenio]

We're missing a class shopping-button to render the expected HCM styles. We only have small-button. Once we add shopping-button, the expected HCM styles will be applied.

Comment 3

[kpatenio]

Attachment: Bug 1879354 - add shopping-button class so that keep closed buttons have consistent HCM styling. r=#shopping-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25aa19a174c0
add shopping-button class so that keep closed buttons have consistent HCM styling. r=shopping-reviewers,jhirsch

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/25aa19a174c0

Comment 6

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly Build 124.0a1 (2024-02-13).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kpatenio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Rares Doghi, Desktop QA]

Updating the main status flag.