1879371 - Add a helper for placing repeated table footer

Status: RESOLVED FIXED

(Core :: Layout: Tables, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

We have this piece of code repeated in nsTableFrame::ReflowChildren five times. It would be nice to add a helper for it.

        if (allowRepeatedFooter) {
          PlaceRepeatedFooter(aReflowInput, tfoot, footerBSize);
        } else if (tfoot && tfoot->IsRepeatable()) {
          tfoot->SetRepeatable(false);
        }

https://searchfox.org/mozilla-central/rev/54c9b4896fdc1e858cd4942f306d877f1f3d195e/layout/tables/nsTableFrame.cpp#2719-2723

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1879371 Part 1 - Move a comment closer to its code in nsTableFrame::ReflowChildren(). r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1879371 Part 2 - Add a helper for placing repeated table footer avoid code duplication. r?#layout

This patch shouldn't change behavior. There was a callsite missed
SetRepeatable(false) when the repeated table footer is not allowed, but I
think it was an oversight rather than intentional.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad5f692c7a6
Part 1 - Move a comment closer to its code in nsTableFrame::ReflowChildren(). r=jwatt
https://hg.mozilla.org/integration/autoland/rev/eb96f3043bf6
Part 2 - Add a helper for placing repeated table footer avoid code duplication. r=jwatt

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2ad5f692c7a6
https://hg.mozilla.org/mozilla-central/rev/eb96f3043bf6