1879463 - Intermittent Assertion failed: (mPath.length() > 0), function ScopedUniqueDirectory, file ../../gtests/common/util.h, line 65.

Status: NEW

(NSS :: Test, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: jschanck [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=446533717&repo=nss-try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/sgnSz-a5TXi_0w0LHCqZZw/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[John Schanck [:jschanck]]

This has been a perma failure on our mac workers for a while. I just ran into it on Linux and tracked it down. It happens because we use an (unseeded) call to rand() to choose a name for a temporary directory.

Here's a (not very serious) patch. Doing something more robust here would be a good first bug for someone.

diff --git gtests/common/util.h gtests/common/util.h
--- gtests/common/util.h
+++ gtests/common/util.h
@@ -13,6 +13,7 @@
 #include <iostream>
 #include <sstream>
 #include <sys/stat.h>
+#include <time.h>
 #include <vector>
 #if defined(_WIN32)
 #include <windows.h>
@@ -90,7 +91,9 @@ class ScopedUniqueDirectory {
     std::stringstream ss;
     ss << prefix;
     // RAND_MAX is at least 32767.
-    ss << std::setfill('0') << std::setw(4) << std::hex << rand() << rand();
+    ss << std::setfill('0') << std::setw(4) << std::hex;
+    ss << time(nullptr);
+    ss << rand();
     // This will overwrite the value of prefix. This is a little inefficient,
     // but at least it makes the code simple.
     ss >> prefix;

Comment 2

[Intermittent Failures Robot]

1 failures in 4009 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• nss-try: 1

Platform and build breakdown:

• mac: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1879463&startday=2024-02-05&endday=2024-02-11&tree=all

Comment 3

[John Schanck [:jschanck]]

Attachment: Bug 1879463 - make gtest ScopedUniqueDirectory names more unique. r=#nss-reviewers

Comment 4

[John Schanck [:jschanck]]

Hm, there must be multiple ways to cause this same error, because the patch didn't work in try.