Closed
Bug 1879609
Opened 2 years ago
Closed 2 years ago
Add New Tab page pinned tab indicator to Open Tabs in Firefox View
Categories
(Firefox :: Firefox View, task)
Firefox
Firefox View
Tracking
()
RESOLVED
FIXED
125 Branch
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: kcochrane, Assigned: nsharpley)
References
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
URLs that have been pinned on the New Tab page should be indicated in Firefox View with a pin icon. This is entirely separate from how we're indicating a tab is pinned via the tab strip, so please be aware of that distinction.
Spec can be seen here
We may need UX to attach an icon here, as the existing pin-12.svg icon used on the New Tab page doesn't include a surrounding stroke whereas the spec indicates we need to have one in Firefox View.
If we import NewTabUtils to opentabs.mjs, we can use something like:
function checkIfPinnedNewTab(url) {
return lazy.NewTabUtils.pinnedLinks.isPinned({ url });
}
Updated•2 years ago
|
Whiteboard: [fidefe-firefox-view]
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → nsharpley
| Assignee | ||
Comment 1•2 years ago
|
||
- added pin icons to the tab row
Updated•2 years ago
|
Attachment #9380043 -
Attachment description: WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab → Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers
Updated•2 years ago
|
Attachment #9380043 -
Attachment description: Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers → WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab
Updated•2 years ago
|
Status: NEW → ASSIGNED
Updated•2 years ago
|
Attachment #9380043 -
Attachment description: WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab → WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers
Updated•2 years ago
|
Attachment #9380043 -
Attachment description: WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers → Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers
Pushed by nsharpley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64915858a170
Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•