Closed Bug 1879609 Opened 2 years ago Closed 2 years ago

Add New Tab page pinned tab indicator to Open Tabs in Firefox View

Categories

(Firefox :: Firefox View, task)

task

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
firefox125 --- fixed

People

(Reporter: kcochrane, Assigned: nsharpley)

References

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

URLs that have been pinned on the New Tab page should be indicated in Firefox View with a pin icon. This is entirely separate from how we're indicating a tab is pinned via the tab strip, so please be aware of that distinction.
Spec can be seen here

We may need UX to attach an icon here, as the existing pin-12.svg icon used on the New Tab page doesn't include a surrounding stroke whereas the spec indicates we need to have one in Firefox View.

If we import NewTabUtils to opentabs.mjs, we can use something like:

function checkIfPinnedNewTab(url) {
  return lazy.NewTabUtils.pinnedLinks.isPinned({ url });
}
Whiteboard: [fidefe-firefox-view]
Assignee: nobody → nsharpley
Attachment #9380043 - Attachment description: WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab → Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers
Attachment #9380043 - Attachment description: Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers → WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab
Status: NEW → ASSIGNED
Attachment #9380043 - Attachment description: WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab → WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers
Attachment #9380043 - Attachment description: WIP: Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers → Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=#fxview-reviewers
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64915858a170 Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Regressions: 1883714
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: