1879752 - Backport upstream fix for possible crash when stopping PipeWire camera

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jan Grulich]

There is a possible crash that can happen because of a possible race condition when camera is stopped and PipeWire backend is used.

# Fatal error in: /builddir/build/BUILD/firefox-122.0/third_party/libwebrtc/modules/video_capture/linux/video_capture_pipewire.cc, line 321
# last system error: 11
# Check failed: !race_checker321.RaceDetected()
# Redirecting call to abort() to mozalloc_abort

This has been fixed in WebRTC and we should backport this fix for it.
Fix is here: https://webrtc-review.googlesource.com/c/src/+/338021

Comment 1

[Jan Grulich]

Attachment: Bug 1879752 - WebRTC backport: Video capture PipeWire - simplify thread and lock annotations r=pehrsons

This is a simple backport of an WebRTC upstream change.

Upstream commit: 541f202354e2b4906935c8db6e54386aa8bc8d1f

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc12e6eecaa8
WebRTC backport: Video capture PipeWire - simplify thread and lock annotations r=pehrsons,webrtc-reviewers

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dc12e6eecaa8