187979 - getcomponentfolder test case fails

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Jimmy Lee]

Build: 2003-01-03-08-trunk(WIN), 2003-01-03-08-trunk(LINUX),
2003-01-03-08-trunk(MAC OS X)

1. From http://jimbob/trigger3.html, select a_getcomponentfolder from the
   Acceptance drop-down and click Trigger case button
2. Click Install button from Software Installation dialog

RESULT:
Dialog returns "script error".

Install.log returns:
-------------------------------------------------------------------------------
http://jimbob/jars/a_getcomponentfolder.xpi  --  01/06/2003 16:06:59
-------------------------------------------------------------------------------

     Acceptance: a_getcomponentfolder
     --------------------------------

     [1/1]	Installing: C:\Program Files\Netscape\122302\a_getcomponentfolder.txt

     Install **FAILED** with error -229  --  01/06/2003 16:06:59

Installscript:
regName = "a_getcomponentfolder";
jarSrc = "smrtupdt.txt";
var vi = "1.0.1.15";

initInstall("Acceptance: a_getcomponentfolder", "acceptance", vi, 0);
f = getFolder("Program");
addFile(regName, vi, jarSrc, f, "a_getcomponentfolder.txt", true);
if (0 == getLastError())
	performInstall();
else
	cancelInstall();
compFolder = getComponentFolder("acceptance" + "/" + regName);
logComment("GetComponentFolder should return path to Program directory: " +
compFolder);

EXPECTED RESULT:
Installation is successful.  It appears the error occurs at:
compFolder = getComponentFolder("acceptance" + "/" + regName);

Comment 1

[Jimmy Lee]

Nominating for beta.  This used to work, and now it doesn't.  By the way, this
broke in 1.2.1.  I don't know how important this API is, but it is a regression.

Comment 2

[Rafael Ebron (:rebron)]

Installer triage team: nsbeta1+/adt3

Comment 3

[Sean Su]

Attachment: patch v1.0

this fixes the problem, but I'm not sure if it's the right thing to do. 
checking with dveditz....

Comment 4

[Daniel Veditz [:dveditz]]

This patch throws away the subdirectory. The right fix is contained in the
125106 uber-patch which contained general nsIFile/intl cleanups. You can't
really separate out just the fix for this one spot though.

Comment 5

[Grace Bush]

fwiw, I am seeing these tests show 'success' now vs cancelled as noted here ,
however they show 'null' as  result

Comment 6

[Sean Su]

problem was fixed along with bug 125106.

both 1 and 2 param flavors of the function should be working now.

Comment 7

[Grace Bush]

verified, test cases returning 'success'