1879800 - Optimize WalkMemoryCacheRunnable's use of nsTArray

Status: RESOLVED FIXED

(Core :: Networking: Cache, task, P2)

Description

[Jens Stutte [:jstutte]]

WalkMemoryCacheRunnable stores a list of cache entries to then walk through it and do mEntryArray.RemoveElementAt(0); on each iteration. This causes unnecessary memcpy operations on the array and during filling and on some iterations eventually also reallocs. We should ensure, that:

• the memory is allocated only once at the beginning for the entire set
• we keep an index for the last run iteration, just nulling out the RefPtr without removing the element
• the memory is freed only once at the very end of WalkMemoryCacheRunnable's lifetime

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1879800 - Avoid WalkMemoryCacheRunnable::mEntryArray to be shifted on each iteration. r?#necko-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b0f24bc9a21
Avoid WalkMemoryCacheRunnable::mEntryArray to be shifted on each iteration. r=necko-reviewers,valentin

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0b0f24bc9a21