Closed Bug 1879820 Opened 1 year ago Closed 4 months ago

Consume user activation when tab for anchor _blank opens

Categories

(Core :: DOM: Core & HTML, task)

task

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: canadahonk, Assigned: edgar)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This should be standardized first, then we should likely write WPTs if not already added.

WIP. Seems kind of hackish but not sure where/how else is best?
Should likely write WPTs for this too.

Assignee: nobody → omedhurst
Status: NEW → ASSIGNED
Attachment #9379477 - Attachment description: WIP: Bug 1879820 - Consume user activation when tab for anchor _blank opens → Bug 1879820 - Consume user activation when tab for anchor _blank opens
Depends on: 1867545
Attachment #9379477 - Attachment description: Bug 1879820 - Consume user activation when tab for anchor _blank opens → WIP: Bug 1879820 - Apply popup blocker for user activated anchor _blank opens
Assignee: omedhurst → nobody
Status: ASSIGNED → NEW
Assignee: nobody → echen

Note to myself:
we meed to handle the case where the submit target is _blank, which also opens a new window. For example:

<form target=_blank><input><button>Submit></button></form>

User activation should be checked and consumed when the form is submitted, whether by clicking the submit button or by calling submit() via script.

Attachment #9379477 - Attachment description: WIP: Bug 1879820 - Apply popup blocker for user activated anchor _blank opens → WIP: Bug 1879820 - Consume user activation when clicking link opens a new window;
Attachment #9379477 - Attachment description: WIP: Bug 1879820 - Consume user activation when clicking link opens a new window; → Bug 1879820 - Consume user activation when clicking link opens a new window;
Attachment #9436825 - Attachment description: WIP: Bug 1879820 - Consume user activation when submitting form opens a new window; → Bug 1879820 - Consume user activation when submitting form opens a new window;
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a5c664192cd Consume user activation when clicking link opens a new window; r=smaug,zcorpan https://hg.mozilla.org/integration/autoland/rev/e139b4496f0b Consume user activation when submitting form opens a new window; r=smaug,zcorpan
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49259 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Upstream PR merged by moz-wptsync-bot
Regressions: 1934807
Regressions: 1940314
Regressions: 1940349

Is bug 1940349 a duplicate of bug 1940314?

Flags: needinfo?(echen)

Yes, and I think they are all duplicates of bug 1934807.

Flags: needinfo?(echen)
Regressions: 1940697
Regressions: 1940868
No longer regressions: 1940868
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: