Closed
Bug 1879868
Opened 2 years ago
Closed 2 years ago
Translations Automatically Popup bottom sheet on Offer Translation
Categories
(Firefox for Android :: Translations, enhancement, P2)
Tracking
()
RESOLVED
FIXED
125 Branch
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: olivia, Assigned: giorga)
References
Details
(Whiteboard: [fxdroid][foundation])
Attachments
(1 file)
This bug is to implement the behavior for offering a translation. The delegate sets this behavior here. The corresponding state is isOfferTranslate.
|
Reporter | |
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P2
|
|
Reporter | |
Updated•2 years ago
|
Blocks: fx-translation-android
Whiteboard: [fxdroid][foundation]
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 1•2 years ago
|
||
Figma flow.
Recommend comparing to Desktop for full behavior as it is highly context dependent.
Testing flow:
- Page must be supported by the engine.
- Always offer must be on with no other settings that might contradict/override the setting, (e.g., Never translate language on the page should not be true too or Never translate this page must not be true.)
- Show the sheet (once)
- Offering should be based on website host and not repeatedly offer in the same browsing session.
|
|
Reporter | |
Comment 2•2 years ago
|
||
The final implemented behavior should be causing the sheet to automatically pop-up.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → giorga
|
||
Comment 3•2 years ago
|
||
|
|
||
Comment 4•2 years ago
|
||
Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/7997bcbcaeb80c5ce081da0afa23436f7249e686
[main] Bug 1879868 - Translations Automatically Popup bottom sheet on Offer Translation
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•