Closed
Bug 1879926
Opened 1 year ago
Closed 1 year ago
Replace History component in sidebar
Categories
(Firefox :: Sidebar, task)
Firefox
Sidebar
Tracking
()
RESOLVED
FIXED
126 Branch
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: sclements, Assigned: nsharpley)
References
(Blocks 1 open bug, Regressed 2 open bugs)
Details
(Whiteboard: [fidefe-sidebar])
Attachments
(1 file)
We want to replace history in the sidebar with lit-based/firefox view components. This should be behind a pref defaulting to false visibility (to preserve existing behavior). This new component would be something like HistorySidebar extends MozLitElement, all start/stop functionality to add and remove listeners and observers can be in connected/disconnected callback.
For this stage we don't need to add the following yet (we'll wait on final specs and telemetry requirements from UX/product):
- no telemetry (just be sure we're not reporting any interactions to firefox view)
- keep elements as links with their default right-click menu
- don't implement the drop down panel list just yet (it is likely to change), default to showing history by date
- do add the search input at the top
- don't add tests yet
- moz-card might be an option instead of card-container
Updated•1 year ago
|
Updated•1 year ago
|
Assignee: nobody → nsharpley
| Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: WIP: Bug 1879926 - Add Lit history component to Sidebar → Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers → WIP: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: WIP: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers → Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers → WIP: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: WIP: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers → Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers → WIP: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Updated•1 year ago
|
Attachment #9390514 -
Attachment description: WIP: Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers → Bug 1879926 - Add Lit history component to Sidebar r=#fxview-reviewers
Pushed by nsharpley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2972a7e11e29
Add Lit history component to Sidebar r=fxview-reviewers,desktop-theme-reviewers,dao,kcochrane,fluent-reviewers,jsudiaman,kpatenio
Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b32bc55017c1
Fix lint failure @ browser/components/sidebar/sidebar.ftl a=lint-fix CLOSED TREE
Comment 4•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2972a7e11e29
https://hg.mozilla.org/mozilla-central/rev/b32bc55017c1
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox126:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Regressions: 1894019
You need to log in
before you can comment on or make changes to this bug.
Description
•