1879934 - Notifications triggered from showNotification but on window context are removed from storage at window close

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Those are supposed to be persistent and thus should never go away.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1879934 - Observe window events only for non-persistent notifications r=asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dd0aa903d7f
Observe window events only for non-persistent notifications r=asuth

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44880 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing assertion failures @ widget/windows/ToastNotification.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/73ca2889eeda977c4f28be1c7db646ddc6cd38a6

Push with failures

Failure log -> Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Closing a notification that is not being handled by nsIAlertsService), at /builds/worker/checkouts/gecko/widget/windows/ToastNotification.cpp

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/883de82d89f9
Observe window events only for non-persistent notifications r=asuth

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/883de82d89f9

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot