1879996 - Implement GetFrameName() for nsCheckboxRadioFrame and nsSelectsAreaFrame

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

nsCheckboxRadioFrame and nsSelectsAreaFrame are shown as Frame and Block in the frame tree dump, which are not meaningful.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1879996 Part 1 - Remove an obsolete comment for nsCheckboxRadioFrame. r?#layout

We've moved GetUsableScreenRect() as a static method into
nsComboboxControlFrame.cpp in
https://hg.mozilla.org/mozilla-central/rev/7f37547c29ff

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1879996 Part 2 - Remove 'virtual' keyword for methods already having 'override'. r?#layout

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1879996 Part 3 - Implement GetFrameName() for nsCheckboxRadioFrame and nsSelectsAreaFrame. r?#layout

Before this patch, nsCheckboxRadioFrame and nsSelectsAreaFrame are shown as
Frame and Block in the frame tree dump. This patch gives them proper names
so that it is easier to find their implementation when looking at the frame tree
dump.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d02843e9fdae
Part 1 - Remove an obsolete comment for nsCheckboxRadioFrame. r=tlouw
https://hg.mozilla.org/integration/autoland/rev/f32be8608ec1
Part 2 - Remove 'virtual' keyword for methods already having 'override'. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/38843b8b1e52
Part 3 - Implement GetFrameName() for nsCheckboxRadioFrame and nsSelectsAreaFrame. r=layout-reviewers,emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d02843e9fdae
https://hg.mozilla.org/mozilla-central/rev/f32be8608ec1
https://hg.mozilla.org/mozilla-central/rev/38843b8b1e52