1880002 - control+e doesn't work in Summary field

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Tooru Fujisawa [:arai]]

https://github.com/mozilla-bteam/bmo/blob/f03c836dbb1a9e051273d9f2cf1e5bd2ac33bf9d/extensions/BugModal/web/bug_modal.js#L1268

    $(window)
        .keydown(function(event) {
            if (!(event.ctrlKey || event.metaKey))
                return;
            switch(String.fromCharCode(event.which).toLowerCase()) {
                // ctrl+e or meta+e = enter edit mode
                case 'e':
                    if (event.shiftKey)
                        return;
                    // don't conflict with text input shortcut
                    if (document.activeElement.nodeNode == 'INPUT' || document.activeElement.nodeName == 'TEXTAREA')
                        return;

it should check nodeName

Comment 1

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1880002 - Do not override control+e handling in INPUT field. (#2190)

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: GitHub Pull Request

Comment 3

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/d638f7d3178147f159009bc8e8c54c4148375189