1880007 - Notification server can't be compiled as C++20 because Windows' <filesystem> header is not compatible with C++20's char8_t

Status: RESOLVED FIXED

(Toolkit :: Alerts Service, task, P3)

Description

[Chris Peterson [:cpeterson]]

Windows' <filesystem> system header file is not compatible with C++20's char8_t, as documented in the clang issue tracker:

https://bugs.llvm.org/show_bug.cgi?id=41132

Instead of compiling the notification server as C++17, just disable char8_t support.

ERROR - /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/experimental/filesystem(45,1): error: declaration of anonymous struct must be a definition
INFO - struct char8_t; /* flag for UTF8 */

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1880007 - Disable C++20's char8_t support in notification server. r?nalexander

Windows' <filesystem> system header file is not compatible with C++20's char8_t, as documented in the clang issue tracker:

https://bugs.llvm.org/show_bug.cgi?id=41132

Instead of compiling the notification server as C++17, just disable char8_t support.

ERROR - /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/experimental/filesystem(45,1): error: declaration of anonymous struct must be a definition
INFO - struct char8_t; /* flag for UTF8 */

Comment 2

[Chris Peterson [:cpeterson]]

Good news! I downloaded that latest MSVC SDK (version 14.39.33519) and its filesystem header has changed the incompatible struct char8_t; // flag for UTF8 declaration to a C++20 compatible name: struct _Char8_t; // flag for UTF8. Since updating the VS SDK will fix this C++20 build error, this workaround isn't necessary.

Comment 3

[Chris Peterson [:cpeterson]]

Since updating the VS SDK will fix this C++20 build error, this workaround isn't necessary.

But I will leave this bug open as a placeholder for this issue until the VS SDK is updated.

Comment 4

[Chris Peterson [:cpeterson]]

Fixed by bug 1880919.