1880011 - mSyncObject->Synchronize() in RenderCompositorANGLE::BeginFrame() is called when it is not necessary.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sotaro Ikeda [:sotaro]]

When RenderDXGITextureHost has keyed mutex, RenderDXGITextureHost::SyncObjectNeeded() should return false. But RenderDXGITextureHost::SyncObjectNeeded() return true. Then the Synchronize() is called when it is not necessary.

This is a regression from Bug 1866412.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1880011 - RenderDXGITextureHost::SyncObjectNeeded()

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1866412

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f6ad5b21119
RenderDXGITextureHost::SyncObjectNeeded() r=gfx-reviewers,lsalzman

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5f6ad5b21119

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9379863 [details]
Bug 1880011 - RenderDXGITextureHost::SyncObjectNeeded()

Beta/Release Uplift Approval Request

• User impact if declined: mSyncObject->Synchronize() is called more than necessary. That increases a risk of Bug 1877726.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just reduces unnecessary mSyncObject->Synchronize() call.
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9379863 [details]
Bug 1880011 - RenderDXGITextureHost::SyncObjectNeeded()

Fx123 is in RC week now, moving over the request.

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9379863 [details]
Bug 1880011 - RenderDXGITextureHost::SyncObjectNeeded()

Cancel the request.