1880069 - Switch-to-tab in a regular tab loads the url already opened in container tabs

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Notes

• Please refer to the following screen recording.

Found in

• Firefox Nightly 124.0a1;

Affected versions

• Firefox Nightly 124.0a1;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 12;

Affected platforms

• Windows 10;
• Ubuntu 22;
• macOS 12;

Unaffected platforms

• N/A;

Preconditions

• browser.urlbar.switchTabs.searchAllContainers set to true

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Open a website in a container tab(eg. Personal).
3. Open a new regular tab and write the title of the previously opened website until the suggestion is present in the address bar.
4. Click on the Switch to tab - Personal button.
5. Open a new regular tab and write the title of the previously opened website.
6. Click on the switch-to-tab(non-container) button from Firefox Suggest section in the address bar.

Expected result

• There should be no switch to tab option present for a non-container tab, since the url is opened only in a container tab.

Actual result

• The website loads in the regular tab.

Regression range

• Not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:oardelean, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Marco Bonardo [:mak]]

The bug is due to deduping not working correctly, both the Places and the InputHistory provider are returning a switch tab result, but InputHistory is not returning the appropriate userContextId, so the Muxer doesn't dedupe them. Taking the bug as Mark is finishing other work.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1880069 - Switch-to-tab result sometimes appears twice with wrong container. r=jteow

The InputHistory (adaptive) provider is not properly reporting the open tab
userContextId, thus the Muxer is unable to dedupe results properly.
This cleans up the query a little bit avoiding numeric indices and fields that
are unused later.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6bac75c3b64
Switch-to-tab result sometimes appears twice with wrong container. r=jteow

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d6bac75c3b64

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is verified as fixed on Firefox Nightly 125.0a1 on macOS 12, Windows 10 and Ubuntu 22.